Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding egress/ingress IPv6 for node-local-dns queries #10396

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Adding egress/ingress IPv6 for node-local-dns queries #10396

merged 1 commit into from
Feb 5, 2024

Conversation

raviranjanelastisys
Copy link
Contributor

@raviranjanelastisys raviranjanelastisys commented Aug 28, 2023 •
edited by floryut
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind feature

What this PR does / why we need it:
We found some error in the node-local-dns pod for IPv6 queries -

[ERROR] plugin/errors: 2 alertmanager-kube-prometheus-stack-alertmanager-0.alertmanager-operated. ANY: dial tcp [2620:fe::fe]:53: i/o timeout
[ERROR] plugin/errors: 2 5185845442857603503.5577735529860551140.cluster.local. HINFO: dial tcp 10.233.3.23:53: i/o timeout
[ERROR] plugin/errors: 2 6681947942670949562.3324415659505387376.in-addr.arpa. HINFO: dial tcp 10.233.3.23:53: i/o timeout
[ERROR] plugin/errors: 2 5216755221347913579.934064619013292502.ip6.arpa. HINFO: dial tcp 10.233.3.23:53: i/o timeout

and allowing the Ipv6 egress fixed the problem in firewall

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Adding egress IPv6 for node-local-dns queries (`k8s_allowed_egress_ipv6_ips`)

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 28, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: raviranjanelastisys (98cb69b)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 28, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @raviranjanelastisys. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 28, 2023
floryut
floryut approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raviranjanelastisys Thank you for the PR
Can you please check CLA ?

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2023
@floryut
Copy link
Member

floryut commented Sep 4, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 4, 2023
@floryut floryut added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 4, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 5, 2023
@raviranjanelastisys raviranjanelastisys changed the title Adding egress IPv6 for node-local-dns queries Adding egress/ingerss IPv6 for node-local-dns queries Sep 8, 2023
@raviranjanelastisys raviranjanelastisys changed the title Adding egress/ingerss IPv6 for node-local-dns queries Adding egress/ingress IPv6 for node-local-dns queries Sep 8, 2023
@raviranjanelastisys
Copy link
Contributor Author

@raviranjanelastisys Thank you for the PR Can you please check CLA ?

@floryut Thanks , i have checked the CLA , let me know if any further actions needed to move this PR forward.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 18, 2023
@raviranjanelastisys raviranjanelastisys force-pushed the rranjan/node-local-dns-egress-ipv6 branch 3 times, most recently from f3b4af4 to 4954514 Compare September 18, 2023 08:19
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 18, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, raviranjanelastisys

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@raviranjanelastisys
Copy link
Contributor Author

Hi Team

Please let me know what else needed to get this PR merged ?

@raviranjanelastisys
Copy link
Contributor Author

@floryut @bozzo @holmsten Can you please check the failing pipeline from your end - https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/5671800704

@raviranjanelastisys
Copy link
Contributor Author

Hi Team

Any luck on this ?

@raviranjanelastisys
Copy link
Contributor Author

Hi Guys

Any update on this ?

@floryut
Copy link
Member

floryut commented Jan 23, 2024

@raviranjanelastisys Can you please try and rebase ? Real sorry about how this PR was left out..

@raviranjanelastisys
Copy link
Contributor Author

@floryut Can you please merge now, I have done the rebase successfully

@floryut floryut merged commit 200b630 into kubernetes-sigs:master Feb 5, 2024
2 of 6 checks passed
@mzaian mzaian mentioned this pull request Apr 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@bozzo bozzo Awaiting requested review from bozzo

@holmsten holmsten Awaiting requested review from holmsten

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@raviranjanelastisys @k8s-ci-robot @floryut