Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[calico] Make version 3.26.1 default #10416

Merged
merged 2 commits into from
Sep 19, 2023
Merged

[calico] Make version 3.26.1 default #10416

merged 2 commits into from
Sep 19, 2023

Conversation

mzaian
Copy link
Contributor

@mzaian mzaian commented Sep 7, 2023 •
edited by floryut
Loading

What type of PR is this?

/kind feature
/kind network

What this PR does / why we need it:
Separate calico-node and calico-cni-plugin service accounts See: projectcalico/calico#7106
This PR makes calico version v3.26.1 default.

Does this PR introduce a user-facing change?:

[calico] Separate calico-node and calico-cni-plugin service accounts and update default calico to v3.26.1

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 7, 2023
@mzaian mzaian mentioned this pull request Sep 7, 2023
Merged
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 7, 2023
@mzaian mzaian mentioned this pull request Sep 7, 2023
Closed
@floryut floryut added the kind/network Network section in the release note label Sep 7, 2023
@mzaian
Copy link
Contributor Author

mzaian commented Sep 11, 2023

Hello @MrFreezeex,

I cannot determine the CI failure. Can you have a look with me.

@MrFreezeex
Copy link
Member

Hmm there is this in the calico node pods:

2023-09-11 12:44:40.817 [INFO][1] cni-installer/<nil> <nil>: CNI plugin version: v3.26.1

2023-09-11 12:44:40.817 [INFO][1] cni-installer/<nil> <nil>: /host/secondary-bin-dir is not writeable, skipping
W0911 12:44:40.817529       1 client_config.go:618] Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This might not work.
2023-09-11 12:44:40.824 [ERROR][1] cni-installer/<nil> <nil>: Unable to create token for CNI kubeconfig error=serviceaccounts "calico-cni-plugin" is forbidden: User "system:serviceaccount:kube-system:calico-node" cannot create resource "serviceaccounts/token" in API group "" in the namespace "kube-system"
2023-09-11 12:44:40.824 [FATAL][1] cni-installer/<nil> <nil>: Unable to create token for CNI kubeconfig error=serviceaccounts "calico-cni-plugin" is forbidden: User "system:serviceaccount:kube-system:calico-node" cannot create resource "serviceaccounts/token" in API group "" in the namespace "kube-system"
==== END logs for container install-cni of pod kube-system/calico-node-6pcq7 ====

Could be related to: https://github.com/projectcalico/calico/pull/7106/files?

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 11, 2023
floryut
floryut approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mzaian Thank you!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, MrFreezeex, mzaian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6b34e3e into kubernetes-sigs:master Sep 19, 2023
63 checks passed
guytet pushed a commit to guytet/kubespray that referenced this pull request Oct 30, 2023
@mzaian
[calico] Make version 3.26.1 default (kubernetes-sigs#10416)
ec25f05 
* [calico] Make version 3.26.1 default

* [calico] Separate calico-node and calico-cni-plugin service accounts

See: projectcalico/calico#7106
@yankay yankay mentioned this pull request Dec 15, 2023
Closed
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@mzaian @pedromcpedro
[calico] Make version 3.26.1 default (kubernetes-sigs#10416)
8826c22 
* [calico] Make version 3.26.1 default

* [calico] Separate calico-node and calico-cni-plugin service accounts

See: projectcalico/calico#7106
@hadi2f244 hadi2f244 mentioned this pull request May 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrFreezeex MrFreezeex MrFreezeex approved these changes

@floryut floryut floryut approved these changes

@cristicalin cristicalin Awaiting requested review from cristicalin

Assignees

@floryut floryut

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/network Network section in the release note lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mzaian @MrFreezeex @k8s-ci-robot @floryut