Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[download] Don't fail on 304 Not Modified #10452

Merged
merged 1 commit into from
Sep 21, 2023
Merged

[download] Don't fail on 304 Not Modified #10452

merged 1 commit into from
Sep 21, 2023

Conversation

sathieu
Copy link
Contributor

@sathieu sathieu commented Sep 19, 2023

i.e when file was not modified since last download

What type of PR is this?

/kind feature

What this PR does / why we need it:

If a file is already downloaded, the timestamp of the file is sent to the server which returns 304 Not Modified. Before this PR, this was considered as a failure.

Don't fail on 304 Not Modified for an already downloaded file

@sathieu
[download] Don't fail on 304 Not Modified
26fd123 
i.e when file was not modified since last download
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 19, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @sathieu. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 19, 2023
@yankay
Copy link
Member

yankay commented Sep 20, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 20, 2023
@yankay
Copy link
Member

yankay commented Sep 20, 2023

Thanks @sathieu
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2023
floryut
floryut approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sathieu Thank you ; lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, sathieu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2023
@k8s-ci-robot k8s-ci-robot merged commit 09f3cae into kubernetes-sigs:master Sep 21, 2023
63 checks passed
@RomainMou RomainMou mentioned this pull request Oct 16, 2023
Closed
@RomainMou RomainMou mentioned this pull request Oct 25, 2023
Closed
RomainMou pushed a commit to RomainMou/kubespray that referenced this pull request Oct 26, 2023
@sathieu @RomainMou
[download] Don't fail on 304 Not Modified (kubernetes-sigs#10452)
178f19f 
i.e when file was not modified since last download
@RomainMou RomainMou mentioned this pull request Oct 26, 2023
Merged
k8s-ci-robot pushed a commit that referenced this pull request Oct 30, 2023
@RomainMou @sathieu
[download] Don't fail on 304 Not Modified (#10452) (#10559)
10679eb 
i.e when file was not modified since last download

Co-authored-by: Mathieu Parent <mathieu.parent@insee.fr>
guytet pushed a commit to guytet/kubespray that referenced this pull request Oct 30, 2023
@sathieu
[download] Don't fail on 304 Not Modified (kubernetes-sigs#10452)
da6da6a 
i.e when file was not modified since last download
unai-ttxu pushed a commit to Stratio/kubespray that referenced this pull request Nov 3, 2023
@RomainMou @sathieu @unai-ttxu
[download] Don't fail on 304 Not Modified (kubernetes-sigs#10452) (ku…
740025b 
…bernetes-sigs#10559)

i.e when file was not modified since last download

Co-authored-by: Mathieu Parent <mathieu.parent@insee.fr>
@VannTen VannTen mentioned this pull request Nov 7, 2023
Closed
@yankay yankay mentioned this pull request Dec 15, 2023
Closed
@VannTen
Copy link
Contributor

VannTen commented Jan 12, 2024

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 12, 2024
@VannTen VannTen mentioned this pull request Jan 12, 2024
Closed
2 tasks
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@sathieu @pedromcpedro
[download] Don't fail on 304 Not Modified (kubernetes-sigs#10452)
d94b1fd 
i.e when file was not modified since last download
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@MrFreezeex MrFreezeex Awaiting requested review from MrFreezeex

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@yankay yankay

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sathieu @k8s-ci-robot @yankay @VannTen @floryut