-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kata-containers] Update configuration-qemu to support kata containers 3.1.3. #10466
[kata-containers] Update configuration-qemu to support kata containers 3.1.3. #10466
Conversation
|
Welcome @Alphadelta14! |
Hi @Alphadelta14. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Namely, the libexec paths have changed since 2.5. This also makes kata_containers_virtio_fs_cache configurable.
72ec435
to
44623b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/check-cla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Alphadelta14
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Alphadelta14, floryut, mzaian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…etes-sigs#10466) Namely, the libexec paths have changed since 2.5. This also makes kata_containers_virtio_fs_cache configurable.
…etes-sigs#10466) Namely, the libexec paths have changed since 2.5. This also makes kata_containers_virtio_fs_cache configurable.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This updates configuration-qemu.toml to the latest 3.1.3 template.
Namely, the libexec paths have changed since 2.5.
This also makes kata_containers_virtio_fs_cache configurable.
Without this change, if you had upgraded from kubespray 1.22 (kata 2.4.1), you would have a dangling /opt/kata/libexec/kata-qemu/virtiofsd that doesn't interact properly with kata 3.1.3.
The newer /opt/kata/libexec/virtiofsd is the correct one.
For reference, the mismatched virtiofsd resulted in errors such as this:
Special notes for your reviewer:
waiting on Corporate CLA to go throughDoes this PR introduce a user-facing change?: