Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kata-containers] Update configuration-qemu to support kata containers 3.1.3. #10466

Merged

Conversation

Alphadelta14
Copy link
Contributor

@Alphadelta14 Alphadelta14 commented Sep 21, 2023

What type of PR is this?
/kind bug

What this PR does / why we need it:

This updates configuration-qemu.toml to the latest 3.1.3 template.
Namely, the libexec paths have changed since 2.5.

This also makes kata_containers_virtio_fs_cache configurable.

Without this change, if you had upgraded from kubespray 1.22 (kata 2.4.1), you would have a dangling /opt/kata/libexec/kata-qemu/virtiofsd that doesn't interact properly with kata 3.1.3.
The newer /opt/kata/libexec/virtiofsd is the correct one.

For reference, the mismatched virtiofsd resulted in errors such as this:

Sep 21 00:11:38 ramiel virtiofsd[41676]: fuse: unknown option(s): `
Sep 21 00:11:38 ramiel virtiofsd[41676]: --cache=always
Sep 21 00:11:38 ramiel virtiofsd[41676]: --shared-dir=/run/kata-containers/shared/sandboxes/74e86dce5baadf07cdedba948df9faf722106913dbdf870022c1c0bd0246c42c/shared'
Sep 21 00:11:38 ramiel kata[41662]: time="2023-09-21T00:11:38.159340765Z" level=error msg="qemu-system-x86_64: -chardev socket,id=char-14283e4a190611ea,path=/run/vc/vm/74e86dce5baadf07cdedba948df9faf722106913dbdf870022c1c0bd0246c42c/vhost-fs.sock: Failed to connect to '/run/vc/vm/74e86dce5baadf07cdedba948df9faf722106913dbdf870022c1c0bd0246c42c/vhost-fs.sock': Connection refused" name=containerd-shim-v2 pid=41662 qemuPid=41677 sandbox=74e86dce5baadf07cdedba948df9faf722106913dbdf870022c1c0bd0246c42c source=virtcontainers/hypervisor subsystem=qemu

Special notes for your reviewer:
waiting on Corporate CLA to go through

Does this PR introduce a user-facing change?:

[kata-containers] Freshens configuration-qemu to latest template compatible with kata-containers 3.1.3.

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 21, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 21, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Alphadelta14 / name: Heather Lapointe (44623b6)

@k8s-ci-robot
Copy link
Contributor

Welcome @Alphadelta14!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 21, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @Alphadelta14. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 21, 2023
Namely, the libexec paths have changed since 2.5.
This also makes kata_containers_virtio_fs_cache configurable.
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Alphadelta14 Thank you for the PR

Could you please check CLA ?

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 22, 2023
@floryut floryut added kind/container-managers Containers section in the release note and removed kind/bug Categorizes issue or PR as related to a bug. labels Sep 22, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 27, 2023
@Alphadelta14
Copy link
Contributor Author

/check-cla

Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Alphadelta14

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 28, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Alphadelta14, floryut, mzaian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ddd7aa8 into kubernetes-sigs:master Sep 28, 2023
63 checks passed
@Alphadelta14 Alphadelta14 deleted the update-kata-config-3.1.3 branch September 28, 2023 16:15
guytet pushed a commit to guytet/kubespray that referenced this pull request Oct 30, 2023
…etes-sigs#10466)

Namely, the libexec paths have changed since 2.5.
This also makes kata_containers_virtio_fs_cache configurable.
@yankay yankay mentioned this pull request Dec 15, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
…etes-sigs#10466)

Namely, the libexec paths have changed since 2.5.
This also makes kata_containers_virtio_fs_cache configurable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/container-managers Containers section in the release note lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants