Cleanup a deprecation warning (ipaddr filter)

[VannTen]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Fix the the deprecation warning related to the ipaddr filter in calico role.

https://docs.ansible.com/ansible/latest/collections/ansible/netcommon/ipaddr_filter.html

Does this PR introduce a user-facing change?:

Cleanup a deprecation warning (ipaddr filter)

[k8s-ci-robot]

Hi @VannTen. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[MrFreezeex]

Hey Max, look like we have crossed path again :D.
Thanks for the PR, cleanup PRs are always very much appreciated 🙏 .

I have a small comment about dependencies, galaxy compat is still somewhat very new in Kubespray and we didn't hear that much from users about it. I think we would be very interested about any improvement in that area. I have left a small comment about dependencies, let me know if you have any insight into that it would super nice! Otherwise lgtm as is.

/lgtm

[MrFreezeex]

I'm wondering what we should do about dependencies in general here, we have some check mostly on ansible core that is required to be 2.14.x currently. I'm wondering how we should handle these things in galaxy though. Do you have insight about that? Maybe we could also add ansible-core there?

[VannTen]

Hi Arthur, long time no see indeed :)
I don't think ansible-core should go there.
From ansible docs on the subject, it looks like it's expected to treat ansible-core specially with the meta/runtime.yml file, and all other collections in the dependencies keys in galaxy.yml.

Note that they encourage collections authors to not depend on other collections, but I don't think kubespay should feel too concerned by that.

[MrFreezeex]

Ok so I checked and I think ansible-core would be the same as the collection ansible.builtin. It seems to follow the same version (~ish). Could you add this to dependencies: ansible.builtin: ">= 2.14.0 <2.15.0 (there's a bug in ansible-core 2.15 preventing to run kubespray currently).

[VannTen]

The way the above documentation is written, it looks to me that ansible-core should be treated specially and not put in dependencies.

We recommend that collections work as standalone, independent units, depending only on ansible-core. However, if your collection must depend on features and functionality from another collection, list the other collection or collections under dependencies in your collection’s galaxy.yml file. Use the meta/runtime.yml file to set the ansible-core version that your collection depends on.

To me that reads like deps check for ansible-core specifically should go in meta/runtime.yml, as it is currently.

[MrFreezeex]

Hmmm ok but then I'm wondering it is really useful to have a requirement on ansible.utils, shouldn't the minimum version of Ansible implicitly include that already somehow ?

[VannTen]

Apparently you can install ansible-core standalone, (but installing ansible would indeed have ansible.utils I think)

[MrFreezeex]

Okok well then nvm both are fine then, as you want 👍

[MrFreezeex]

And thanks for the valuable insights into this 🙏

[MrFreezeex]

/ok-to-test

[yankay]

/lgtm

[VannTen]

Just occurred to me that I could just as well fix the other instances of ipaddr

[MrFreezeex]

/lgtm

[floryut]

@VannTen Thank you 👍

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, MrFreezeex, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment