Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[containerd] Add option to enable cdi for containerd #10603

Merged
merged 1 commit into from
Nov 14, 2023
Merged

[containerd] Add option to enable cdi for containerd #10603

merged 1 commit into from
Nov 14, 2023

Conversation

noama-nv
Copy link
Contributor

@noama-nv noama-nv commented Nov 7, 2023

What type of PR is this?
/kind feature

What this PR does / why we need it:
Add option to enable CDI for containerd which is by default disabled.
https://github.com/cncf-tags/container-device-interface#why-is-cdi-needed
https://github.com/cncf-tags/container-device-interface#containerd-configuration

Which issue(s) this PR fixes:

Fixes #10598

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
Does this PR introduce a user-facing change?:

[containerd] Add Boolean option `enable_cdi` to enable cdi (false by default)

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 7, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @krembu. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 7, 2023
@mzaian
Copy link
Contributor

mzaian commented Nov 7, 2023

Thanks @krembu

/kind container-managers
/ok-to-test

@k8s-ci-robot k8s-ci-robot added kind/container-managers Containers section in the release note ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 7, 2023
@mzaian mzaian changed the title add option to enable cdi for containerd [containerd] add option to enable cdi for containerd Nov 7, 2023
@mzaian mzaian changed the title [containerd] add option to enable cdi for containerd [containerd] Add option to enable cdi for containerd Nov 7, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2023
Copy link
Contributor

@r0b2g1t r0b2g1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@noama-nv
Copy link
Contributor Author

can we merge?

@mzaian mzaian requested a review from r0b2g1t November 14, 2023 16:10
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krembu lgtm

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, krembu, mzaian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit cbd3a83 into kubernetes-sigs:master Nov 14, 2023
63 checks passed
@noama-nv noama-nv deleted the CDI branch November 14, 2023 16:40
@yankay yankay mentioned this pull request Dec 15, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/container-managers Containers section in the release note kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to enable Cdi for containerd
5 participants