Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cert-manager] upgrade to v1.13.2 #10616

Merged
merged 1 commit into from
Jan 5, 2024
Merged

[cert-manager] upgrade to v1.13.2 #10616

merged 1 commit into from
Jan 5, 2024

Conversation

liuxu623
Copy link
Contributor

What type of PR is this?
/kind feature

Does this PR introduce a user-facing change?:

[cert-manager] upgrade to v1.13.2

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 13, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @liuxu623. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 13, 2023
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 13, 2023
@liuxu623
Copy link
Contributor Author

@cristicalin PTAL

@yankay
Copy link
Member

yankay commented Nov 15, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 15, 2023
@mzaian
Copy link
Contributor

mzaian commented Nov 15, 2023

Hello @liuxu623

It just confuses me that you changes some of the sources which refers to the cert-manager manifests. because I cannot find the location you're changing and still they are here https://github.com/cert-manager/cert-manager/tree/master/deploy/charts/cert-manager/templates

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2023
@liuxu623
Copy link
Contributor Author

Hello @liuxu623

It just confuses me that you changes some of the sources which refers to the cert-manager manifests. because I cannot find the location you're changing and still they are here https://github.com/cert-manager/cert-manager/tree/master/deploy/charts/cert-manager/templates

/hold

@mzaian I just copy from https://github.com/cert-manager/cert-manager/releases/download/v1.13.2/cert-manager.crds.yaml and https://github.com/cert-manager/cert-manager/releases/download/v1.13.2/cert-manager.yaml

@mzaian
Copy link
Contributor

mzaian commented Nov 16, 2023

Hello @liuxu623
It just confuses me that you changes some of the sources which refers to the cert-manager manifests. because I cannot find the location you're changing and still they are here https://github.com/cert-manager/cert-manager/tree/master/deploy/charts/cert-manager/templates
/hold

@mzaian I just copy from https://github.com/cert-manager/cert-manager/releases/download/v1.13.2/cert-manager.crds.yaml and https://github.com/cert-manager/cert-manager/releases/download/v1.13.2/cert-manager.yaml

Okay but the source comments was intended to be the github paths. Maybe leave it as it's to avoid the confusion.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 16, 2023
@liuxu623
Copy link
Contributor Author

Hello @liuxu623
It just confuses me that you changes some of the sources which refers to the cert-manager manifests. because I cannot find the location you're changing and still they are here https://github.com/cert-manager/cert-manager/tree/master/deploy/charts/cert-manager/templates
/hold

@mzaian I just copy from https://github.com/cert-manager/cert-manager/releases/download/v1.13.2/cert-manager.crds.yaml and https://github.com/cert-manager/cert-manager/releases/download/v1.13.2/cert-manager.yaml

Okay but the source comments was intended to be the github paths. Maybe leave it as it's to avoid the confusion.

@mzaian done, PTAL

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 28, 2023
@mzaian
Copy link
Contributor

mzaian commented Nov 29, 2023

Hello @liuxu623

Could you please rebase so we can have a final look before merging this.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 29, 2023
@liuxu623
Copy link
Contributor Author

Hello @liuxu623

Could you please rebase so we can have a final look before merging this.

@mzaian done

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2023
MrFreezeex
MrFreezeex approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 12, 2023
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 12, 2023
@liuxu623
Copy link
Contributor Author

@mzaian @MrFreezeex Hi, I just rebased and make CI passed, PTAL

@mzaian
Copy link
Contributor

mzaian commented Dec 13, 2023

@mzaian @MrFreezeex Hi, I just rebased and make CI passed, PTAL

Thanks a lot

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2023
@liuxu623
Copy link
Contributor Author

@cristicalin Hi,PTAL

@liuxu623
Copy link
Contributor Author

liuxu623 commented Jan 5, 2024

@yankay Hi, could you help me merge this PR?

@yankay
Copy link
Member

yankay commented Jan 5, 2024

Thanks @liuxu623
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liuxu623, MrFreezeex, mzaian, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yankay
Copy link
Member

yankay commented Jan 5, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 08c0b34 into kubernetes-sigs:master Jan 5, 2024
64 checks passed
@liuxu623 liuxu623 deleted the upgrade-cert-manager branch January 5, 2024 03:48
ledroide pushed a commit to ledroide/kubespray that referenced this pull request Jan 9, 2024
@liuxu623 @ledroide
[cert-manager] upgrade to v1.13.2 (kubernetes-sigs#10616)
5de2f3a
@yankay yankay mentioned this pull request Jan 12, 2024
Closed
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@liuxu623 @pedromcpedro
[cert-manager] upgrade to v1.13.2 (kubernetes-sigs#10616)
70e3296
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzaian mzaian mzaian approved these changes

@cristicalin cristicalin Awaiting requested review from cristicalin

@MrFreezeex MrFreezeex Awaiting requested review from MrFreezeex

Assignees

@mzaian mzaian

@MrFreezeex MrFreezeex

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@liuxu623 @k8s-ci-robot @yankay @mzaian @MrFreezeex