crictl allow setting grace period for stop containers upon reset

[krembu]

What type of PR is this?
/kind feature

What this PR does / why we need it:
Kubespray upon cluster reset has default 0 second or no grace period for stopping containers. we would like to allow containers to gracefully terminate themselves given a cri_stop_containers_grace_period.

# crictl stop container grace period
cri_stop_containers_grace_period: 0

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
allow kubespray user to set grace period for stop containers upon cluster reset
keep same default to 0 as was before this change

crictl allow setting grace period for stop containers upon reset (using `cri_stop_containers_grace_period`)

[k8s-ci-robot]

Hi @krembu. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yankay]

/ok-to-test

[krembu]

sorry for bumping another patch. the parameter was wrongly place. corrected.

[krembu]

# crictl --help | grep timeout
   --timeout value, -t value           Timeout of connecting to the server in seconds (e.g. 2s, 20s.). 0 or less is set to default (default: 2s)

# crictl stop --help
NAME:
   crictl stop - Stop one or more running containers

USAGE:
   crictl stop [command options] CONTAINER-ID [CONTAINER-ID...]

OPTIONS:
   --timeout value, -t value  **Seconds to wait to kill the container after a graceful stop is requested (default: 0)**
   --help, -h                 show help

[VannTen]

The same option name between the main and sub command is confusing for sure 😮‍💨

[krembu]

can we merge?

[yankay]

Thanks @krembu
The code is OK.
/lgtm

[floryut]

@krembu Thank you for the PR 👍

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, krembu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment