Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.23] Fix calico-node in etcd mode #10768

Merged

Conversation

VannTen
Copy link
Contributor

@VannTen VannTen commented Jan 4, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:
Backport of #10438 + its test (#10722 and #10725)

Does this PR introduce a user-facing change?:

Fix calico-node in etcd mode.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 4, 2024
@VannTen VannTen force-pushed the fix/2.23/calico-etcd branch 4 times, most recently from 0a32ba7 to 6dc58c5 Compare January 8, 2024 09:57
VannTen and others added 3 commits January 11, 2024 14:22
…sigs#10725)

* Rename aio to all-in-one and document it

ADTM.
Acronyms don't tell much.

* Refactor vm_count in tests provisioning
* Add multinode ci layout

* Add test case for calico using etcd datastore
* Calico : add ETCD endpoints to install-cni container

* Calico : remove nodename from configmap in etcd mode
@VannTen
Copy link
Contributor Author

VannTen commented Jan 11, 2024

/cc @cyclinder

@cyclinder
Copy link
Contributor

thanks @VannTen

/lgtm
/cc @floryut @yankay

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2024
@yankay
Copy link
Member

yankay commented Jan 12, 2024

@VannTen Nice fix

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VannTen, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3d76c30 into kubernetes-sigs:release-2.23 Jan 12, 2024
64 checks passed
@VannTen VannTen mentioned this pull request Jan 12, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants