Fix file loss during download #10779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
ErikJiang
force-pushed
the
update_offline_file_download
branch
from
973c5e1
to
44d6afe
Compare
|
You mean wget error code is only affected by the last file it fetches ? Checking it once does not work ? |
$ cat files.list
https://dl.k8s.io/release/v1.25.13/bin/linux/amd64/kubeadm
https://dl.k8s.io/release/v1.25.13/bin/linux/amd64/kubelet
https://dl.k8s.io/release/v1.25.13/bin/linux/amd64/kubectl
$ wget -x -P tmp -i files.list@VannTen For example, in this case, if I get an error while downloading a |
|
Ah ok ! I thought that you wanted "termination instead of masking the error", not "early termination" ^^.
The change makes more sense that way
/lgtm
|
k8s-ci-robot
added
the
lgtm
|
Thanks @ErikJiang |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ErikJiang, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
pedro-peter
pushed a commit
to pedro-peter/kubespray
that referenced
this pull request
May 8, 2024
Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
When using the
wget -icommand to download files, if a file fails to download during the process, the process will not exit. Instead, it will continue downloading the remaining URLs. This results in a problem where the downloaded content is missing the failed files.The following image is an example:
Furthermore, I haven't found any parameters in
wget -ithat would allow the process to be interrupted when an error occurs. Therefore, one approach is to iterate through each line infiles.listand handle the download requests for each URL individually.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: