Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.23] Fix download retry when get_url has no status_code. (#10613) #10791

Merged
merged 1 commit into from
Jan 15, 2024
Merged

[2.23] Fix download retry when get_url has no status_code. (#10613) #10791

merged 1 commit into from
Jan 15, 2024

Conversation

VannTen
Copy link
Contributor

@VannTen VannTen commented Jan 12, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:
Backport of #10613 (fix #10494 which should be present in 2.23)

Does this PR introduce a user-facing change?:

Fix download retry when get_url has no status_code

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 12, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 12, 2024
@VannTen VannTen mentioned this pull request Jan 12, 2024
Closed
2 tasks
@RomainMou @VannTen
Fix download retry when get_url has no status_code. (kubernetes-sigs#…
430e1cb 
…10613)

* Fix download retry when get_url has no status_code.

* Fix until clause in download role.
@VannTen VannTen changed the title Fix download retry when get_url has no status_code. (#10613) [2.23] Fix download retry when get_url has no status_code. (#10613) Jan 14, 2024
@yankay
Copy link
Member

yankay commented Jan 15, 2024

Thanks @VannTen
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2024
@VannTen
Copy link
Contributor Author

VannTen commented Jan 15, 2024

/cc @jayonlau @MrFreezeex

MrFreezeex
MrFreezeex approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrFreezeex, VannTen, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c264ae3 into kubernetes-sigs:release-2.23 Jan 15, 2024
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrFreezeex MrFreezeex MrFreezeex approved these changes

@cristicalin cristicalin Awaiting requested review from cristicalin

@oomichi oomichi Awaiting requested review from oomichi

@jayonlau jayonlau Awaiting requested review from jayonlau

Assignees

@MrFreezeex MrFreezeex

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@VannTen @yankay @k8s-ci-robot @MrFreezeex @RomainMou