Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upgrades.md with serial=1 for rolling updates #10837

Merged
merged 3 commits into from Jan 29, 2024

Conversation

titansmc
Copy link
Contributor

@titansmc titansmc commented Jan 24, 2024

modify env serial to have real rolling upgrades

What type of PR is this?

/kind documentation

What this PR does / why we need it:
Clear explanation of rolling upgrade

Update upgrades.md with serial=1 for rolling updates

 modify env serial to have real rolling upgrades
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 24, 2024
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 24, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @titansmc. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 24, 2024
@yankay
Copy link
Member

yankay commented Jan 25, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 25, 2024
@VannTen
Copy link
Contributor

VannTen commented Jan 25, 2024

Uh, I though this was documented...
It does not fit in that section (Node-based upgrade) though, it should either be in "Graceful upgrade" or in docs/vars.md.
More importantly, "one node at a time" is just a just a special case.
I think we should document that this is just the Ansible "serial" applied to some of our plays (and link to that in Ansible docs) or explicit point out what it does.

change section for serial
docs/upgrades.md Outdated Show resolved Hide resolved
Co-authored-by: Kundan Kumar <kundan.kumar@india.nec.com>
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@titansmc Thank you, approving the idea of the PR, waiting on lgtm when final version is ready 😉

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, titansmc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2024
@yankay
Copy link
Member

yankay commented Jan 29, 2024

Thanks a lot @titansmc
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0ddf872 into kubernetes-sigs:master Jan 29, 2024
65 checks passed
@titansmc titansmc deleted the patch-1 branch January 29, 2024 08:17
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
…#10837)

* Update upgrades.md

 modify env serial to have real rolling upgrades

* Update upgrades.md

change section for serial

* Update docs/upgrades.md

Co-authored-by: Kundan Kumar <kundan.kumar@india.nec.com>

---------

Co-authored-by: Kundan Kumar <kundan.kumar@india.nec.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants