Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download hash script: auto discover versions #10849

Merged

Conversation

VannTen
Copy link
Contributor

@VannTen VannTen commented Jan 29, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:

  • Iterate over patch versions from a given minor
  • Auto-discover current minors from checksums.yml if no explicit minor version is passed to the scripts

Special notes for your reviewer:
If we can then hook other stuff into that script, we should be able to automate the "Update versions" PR and outsource them to a bot (Prow I guess)
/cc @mzaian @floryut @MrFreezeex

Does this PR introduce a user-facing change?:

Download hash script: auto discover versions 

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 29, 2024
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me, but I am not sure if the automated PR/bot system should use the .py script that only take care of kubernetes version or the .sh version that does all the other tools as well. I guess it could be both depending on what we want to do 🤷‍♂️
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2024
@VannTen
Copy link
Contributor Author

VannTen commented Jan 29, 2024

The change looks good to me, but I am not sure if the automated PR/bot system should use the .py script that only take care of kubernetes version or the .sh version that does all the other tools as well. I guess it could be both depending on what we want to do

I'm inclined to think python is more maintainable on the long-term. I admit I find it hard to review #10713 because of that
/assign @yankay
(approval)

@MrFreezeex
Copy link
Member

I'm inclined to think python is more maintainable on the long-term. I admit I find it hard to review #10713 because of

Well maintainability also depends on everyone familiarity with the language and is quite subjective but apart from that the sh variant handles a lot more things than the py variant. The sh script handles all the checksum for everything (~15 different software probably something like that) and many of those has some specifics that we have to handle there. So I am not opposed of getting rid of the .sh script but there is a lot of work that has to be done on the .py variant to get up to speed...

@VannTen
Copy link
Contributor Author

VannTen commented Jan 29, 2024 via email

@yankay
Copy link
Member

yankay commented Jan 30, 2024

Thanks @VannTen for the great feature :-)

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrFreezeex, VannTen, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2024
@k8s-ci-robot k8s-ci-robot merged commit ee8b909 into kubernetes-sigs:master Jan 30, 2024
65 checks passed
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
* Download patches version automatically from a minor

* Automate versions discovery for hash download

* Small refactoring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants