Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for configuring nat outgoing ipv6 #10866

Conversation

anders-elastisys
Copy link
Contributor

@anders-elastisys anders-elastisys commented Feb 1, 2024

What type of PR is this?

/kind documentation

What this PR does / why we need it:

The variable nat_outgoing_ipv6 is not documented anywhere, and it needs to be enabled if you want outgoing ipv6 traffic from pods.

Also fixed the value set for calico_vxlan_mode_ipv6.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add documentation for configuring nat outgoing ipv6

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 1, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @anders-elastisys. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 1, 2024
@VannTen
Copy link
Contributor

VannTen commented Feb 1, 2024

We should rather add the value alongside nat_outgoing in roles/network_plugin/calico_defaults/defaults/main.yml, I think

@anders-elastisys
Copy link
Contributor Author

@VannTen have it in both? The reason for this PR is to have it documented somewhere, preferably in a markdown file so that is easier to find and to know how to configure. But I agree, it should be defined in the role as well, I will add it.

@VannTen
Copy link
Contributor

VannTen commented Feb 1, 2024 via email

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2024
@yankay
Copy link
Member

yankay commented Feb 2, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 2, 2024
@anders-elastisys anders-elastisys force-pushed the anders-elastisys/add-ipv6-vars-to-docs branch from f0d156a to e48bf27 Compare February 5, 2024 09:08
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2024
@VannTen
Copy link
Contributor

VannTen commented Feb 5, 2024

/lgtm
@anders-elastisys please add NONE in the changelog entry in the PR description so it will be correctly classified by the release script
/hold
/assign @yankay
(for approval)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2024
@yankay yankay requested a review from cyclinder February 5, 2024 11:28
Copy link
Contributor

@cyclinder cyclinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Can you also add this to inventory/sample/group_vars/k8s_cluster/k8s-net-calico.yml?

# Enables Internet connectivity from containers
# nat_outgoing: true
# nat_outgoing_ipv6: false

@anders-elastisys anders-elastisys force-pushed the anders-elastisys/add-ipv6-vars-to-docs branch from e48bf27 to 484ee55 Compare February 5, 2024 13:28
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2024
@anders-elastisys
Copy link
Contributor Author

@cyclinder added now, PTAL

@VannTen
Copy link
Contributor

VannTen commented Feb 5, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2024
@cyclinder
Copy link
Contributor

Thanks

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2024
@yankay
Copy link
Member

yankay commented Feb 6, 2024

Thanks @anders-elastisys @VannTen @cyclinder
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anders-elastisys, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit c698790 into kubernetes-sigs:master Feb 6, 2024
65 checks passed
dabeck pushed a commit to fino-digital/kubespray that referenced this pull request May 7, 2024
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants