Don't try to set permissions recursively on cache+staging directory #10900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should avoid permissions problems when the user creating the directory and the user creating the content are different (when containers images are saved by root for instances, because the user can't use the container runtime).
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
the
size/XS
floryut
approved these changes
Feb 9, 2024
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, mzaian, VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dabeck
pushed a commit
to fino-digital/kubespray
that referenced
this pull request
May 7, 2024
…ubernetes-sigs#10900) This should avoid permissions problems when the user creating the directory and the user creating the content are different (when containers images are saved by root for instances, because the user can't use the container runtime).
pedro-peter
pushed a commit
to pedro-peter/kubespray
that referenced
this pull request
May 8, 2024
…ubernetes-sigs#10900) This should avoid permissions problems when the user creating the directory and the user creating the content are different (when containers images are saved by root for instances, because the user can't use the container runtime).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This should avoid permissions problems when the user creating the
directory and the user creating the content are different (when
containers images are saved by root for instances, because the user
can't use the container runtime).
Which issue(s) this PR fixes:
Fixes #10051
Special notes for your reviewer:
We should probably also fix the "user selection" in the download role which looks a bit bad. But that should already workaround the permissions issue linked above.
If you're aware of adverse effects of doing this, please tell ^.
Does this PR introduce a user-facing change?: