Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use run_once for checking ansible version instead of localhost #10908

Merged

Conversation

VannTen
Copy link
Contributor

@VannTen VannTen commented Feb 9, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:
The assert module does not connect to the host anyway, and this avoids
skipping the assert when running with --limit.

Which issue(s) this PR fixes:

Fixes #10831

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Kubespray ansible version checks are now performed even when running with `--limit`

The `assert` module does not connect to the host anyway, and this avoids
skipping the assert when running with --limit.
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 9, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 9, 2024
Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @VannTen

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mzaian, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2024
@k8s-ci-robot k8s-ci-robot merged commit ef7197f into kubernetes-sigs:master Feb 9, 2024
65 checks passed
dabeck pushed a commit to fino-digital/kubespray that referenced this pull request May 7, 2024
…netes-sigs#10908)

The `assert` module does not connect to the host anyway, and this avoids
skipping the assert when running with --limit.
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
…netes-sigs#10908)

The `assert` module does not connect to the host anyway, and this avoids
skipping the assert when running with --limit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running upgrade-cluster.yml with --limit does not check ansible version
3 participants