do not disable SELinux surreptitiously

[rptaylor]

What type of PR is this?
/kind bug

What this PR does / why we need it:
I would argue that Kubespray should be secure by default, not disable SELinux by default. The SELinux default configuration is targeted and enforcing on EL-based operating systems, so I would only expect applications/deployments such as Kubespray to change this secure by default system setting if it is a workaround for specific documented issues. It's a lot easier to start secure by default when first deploying a cluster, making sure everything works when going through the testing and commissioning process at first, than after the fact when everything has already been deployed and running for years.

But anyway if SELinux is being disabled by default, it must not be done in a secretive way, hiding the change from users and concealing the fact that an important security layer is being disabled!!

Special notes for your reviewer:

This PR removes changed_when: False so that users can see that a change has been applied when Kubespray is disabling SELinux.

Does this PR introduce a user-facing change?:

Do not disable SELinux surreptitiously

[k8s-ci-robot]

Hi @rptaylor. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[VannTen]

/lgtm
Though is arguably more documentation than bug
/remove-kind bug
/kind documentation

Looks like the selinux thing is an eternal TODO state, apparently it was done like this 8 years ago: 8127e8f

/assign @cristicalin @floryut

[rptaylor]

/assign @cristicalin

[yankay]

/ok-to-test

[yankay]

Thanks @rptaylor
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rptaylor, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [yankay]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment