-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Terraform-Openstack] Add optional Octavia loadbalancer for Master Nodes #10924
Conversation
Welcome @jaszil! |
Hi @jaszil. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaszil Thank you, can you check the CI ?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, jaszil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @jaszil |
…des (kubernetes-sigs#10924) * terraform-openstack add optional master lb * remove unnecessary spaces * remove unnecessary spaces * fix ci warnings
…des (kubernetes-sigs#10924) * terraform-openstack add optional master lb * remove unnecessary spaces * remove unnecessary spaces * fix ci warnings
What type of PR is this?
/kind feature
What this PR does / why we need it:
Added possibility to build an Openstack octavia loadbalancer for the Kubernetes Api.
The LoadBalancer is useful to make the cluster reachable from outside if only k8s_masters_no_floating_ip is set
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: