scripts: ignore download_hash download failures #10998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary names on github releases often change and this script might break because of that, this commit allow to ignore these failures as a mean to be able to run the script anyway. Signed-off-by: Arthur Outhenin-Chalandre <arthur@cri.epita.fr>
Signed-off-by: Arthur Outhenin-Chalandre <arthur@cri.epita.fr>
k8s-ci-robot
added
kind/flake
k8s-ci-robot
added
the
size/XS
k8s-ci-robot
added
lgtm
Signed-off-by: Arthur Outhenin-Chalandre <arthur@cri.epita.fr>
k8s-ci-robot
removed
the
lgtm
|
Ah I realized that crio also now support ppc64le so adding that as well sorry for the back and forth |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrFreezeex, mzaian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pedro-peter
pushed a commit
to pedro-peter/kubespray
that referenced
this pull request
Mar 23, 2024
* scripts: ignore download_hash download failures Binary names on github releases often change and this script might break because of that, this commit allow to ignore these failures as a mean to be able to run the script anyway. Signed-off-by: Arthur Outhenin-Chalandre <arthur@cri.epita.fr> * scripts: use sha256sums for crio as well Signed-off-by: Arthur Outhenin-Chalandre <arthur@cri.epita.fr> * scripts: add ppc64le support for crio Signed-off-by: Arthur Outhenin-Chalandre <arthur@cri.epita.fr> --------- Signed-off-by: Arthur Outhenin-Chalandre <arthur@cri.epita.fr>
dabeck
pushed a commit
to fino-digital/kubespray
that referenced
this pull request
May 7, 2024
* scripts: ignore download_hash download failures Binary names on github releases often change and this script might break because of that, this commit allow to ignore these failures as a mean to be able to run the script anyway. Signed-off-by: Arthur Outhenin-Chalandre <arthur@cri.epita.fr> * scripts: use sha256sums for crio as well Signed-off-by: Arthur Outhenin-Chalandre <arthur@cri.epita.fr> * scripts: add ppc64le support for crio Signed-off-by: Arthur Outhenin-Chalandre <arthur@cri.epita.fr> --------- Signed-off-by: Arthur Outhenin-Chalandre <arthur@cri.epita.fr>
pedro-peter
pushed a commit
to pedro-peter/kubespray
that referenced
this pull request
May 8, 2024
* scripts: ignore download_hash download failures Binary names on github releases often change and this script might break because of that, this commit allow to ignore these failures as a mean to be able to run the script anyway. Signed-off-by: Arthur Outhenin-Chalandre <arthur@cri.epita.fr> * scripts: use sha256sums for crio as well Signed-off-by: Arthur Outhenin-Chalandre <arthur@cri.epita.fr> * scripts: add ppc64le support for crio Signed-off-by: Arthur Outhenin-Chalandre <arthur@cri.epita.fr> --------- Signed-off-by: Arthur Outhenin-Chalandre <arthur@cri.epita.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind flake
What this PR does / why we need it:
Binary names on github releases often change and this script might break because of that, this commit allow to ignore these failures as a mean to be able to run the script anyway.
It also add support for downloading sha256sums for crio archives instead of the actual tarballs
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: