Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubelet systemd service default allowed IP addresses for cluster hardening #11061

Conversation

bmelbourne
Copy link
Contributor

@bmelbourne bmelbourne commented Apr 7, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

Adds localhost link-local {{ kube_pods_subnet }} (default 10.233.64.0/18) to the list of allowed IP addresses IPAddressAllow in the kubelet.service configuration to resolve an issue preventing kube-proxy pods from starting correctly when kubelet_systemd_hardening: true is applied to Kubernetes clusters.

Which issue(s) this PR fixes:

Fixes #10744

Special notes for your reviewer:

None.

Does this PR introduce a user-facing change?:

None.

…er hardening

Signed-off-by: bmelbourne <barry.melbourne0@gmail.com>
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 7, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @bmelbourne. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 7, 2024
@yankay
Copy link
Member

yankay commented Apr 8, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 8, 2024
@bmelbourne
Copy link
Contributor Author

@yankay
Is it possible for me to retry the failed CI jobs? I can't seem to find a retry button anywhere in the GitLab UI.

@yankay
Copy link
Member

yankay commented Apr 10, 2024

Thanks @bmelbourne
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 10, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmelbourne, mzaian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit 1b870a1 into kubernetes-sigs:master Apr 11, 2024
60 checks passed
@bmelbourne bmelbourne deleted the fix-kubelet-allowed-ip-addresses branch April 11, 2024 07:59
dabeck pushed a commit to fino-digital/kubespray that referenced this pull request May 7, 2024
…er hardening (kubernetes-sigs#11061)

Signed-off-by: bmelbourne <barry.melbourne0@gmail.com>
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
…er hardening (kubernetes-sigs#11061)

Signed-off-by: bmelbourne <barry.melbourne0@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubelet systemd Hardening default IP ranges
4 participants