Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for cilium 1.15 and update cilium to v1.15.4 #11106

Merged
merged 1 commit into from Apr 24, 2024

Conversation

deveshk0
Copy link
Contributor

@deveshk0 deveshk0 commented Apr 22, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Adds support for Cilium 1.15.
  • Update default cilium version to v1.15.4

Which issue(s) this PR fixes:

Fixes #10972

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

- Adds support for cilium v1.15
- Adds support for `cilium_l2announcements` to replace metallb with cilium l2 announcements, defaults to `false`
- Adds support for `cilium_loadbalancer_mode` to switch bpf-lb-mode between snat, dsr or hybrid, default to `snat`

Copy link

linux-foundation-easycla bot commented Apr 22, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: deveshk0 / name: Devesh Kumar (a5b7281)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 22, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @deveshk0!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 22, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @deveshk0. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 22, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 22, 2024
Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 22, 2024
@yankay
Copy link
Member

yankay commented Apr 23, 2024

HI @cyclinder

Would you please help to review it.

@cyclinder
Copy link
Contributor

@yankay sure! I'll take a look soon.

Copy link
Contributor

@cyclinder cyclinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! @deveshk0, overall look LGTM, only a comment.

@deveshk0 deveshk0 requested a review from cyclinder April 23, 2024 07:52
@cyclinder
Copy link
Contributor

/lgtm
/cc @yankay

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2024
@deveshk0
Copy link
Contributor Author

@yankay can you approve this?

@yankay
Copy link
Member

yankay commented Apr 24, 2024

Thanks @deveshk0
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deveshk0, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2024
@k8s-ci-robot k8s-ci-robot merged commit eee5b58 into kubernetes-sigs:master Apr 24, 2024
60 checks passed
@mzaian mzaian added the kind/network Network section in the release note label May 6, 2024
dabeck pushed a commit to fino-digital/kubespray that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/network Network section in the release note lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bump cilium from v1.13.4 to v1.15.1
5 participants