Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use official rockylinux vagrant boxes + add version 9 #11160

Merged
merged 1 commit into from
May 6, 2024
Merged

Use official rockylinux vagrant boxes + add version 9 #11160

merged 1 commit into from
May 6, 2024

Conversation

VannTen
Copy link
Contributor

@VannTen VannTen commented May 3, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:
Ease of testing locally

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 3, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 3, 2024
MrFreezeex
MrFreezeex approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2024
@VannTen
Copy link
Contributor Author

VannTen commented May 4, 2024 via email

@yankay
Copy link
Member

yankay commented May 6, 2024

Thanks @VannTen
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrFreezeex, VannTen, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit 21e8809 into kubernetes-sigs:master May 6, 2024
60 checks passed
dabeck pushed a commit to fino-digital/kubespray that referenced this pull request May 7, 2024
@VannTen @dabeck
Use official rockylinux vagrant boxes + add version 9 (kubernetes-sig…
636493c 
…s#11160)
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@VannTen @pedromcpedro
Use official rockylinux vagrant boxes + add version 9 (kubernetes-sig…
d631a8c 
…s#11160)
Rickkwa pushed a commit to Rickkwa/kubespray that referenced this pull request Jun 26, 2024
@VannTen @Rickkwa
Use official rockylinux vagrant boxes + add version 9 (kubernetes-sig…
26382db 
…s#11160)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrFreezeex MrFreezeex MrFreezeex approved these changes

@cyclinder cyclinder Awaiting requested review from cyclinder

Assignees

@MrFreezeex MrFreezeex

@floryut floryut

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@VannTen @yankay @k8s-ci-robot @MrFreezeex @floryut