Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update external huawei cloud controller to 0.26.8 #11172

Merged
merged 4 commits into from May 8, 2024
Merged

Update external huawei cloud controller to 0.26.8 #11172

merged 4 commits into from May 8, 2024

Conversation

dabeck
Copy link
Contributor

@dabeck dabeck commented May 7, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Update the default version of the external huawei cloud controller to 0.26.8

Special notes for your reviewer:

See: kubernetes-sigs/cloud-provider-huaweicloud@v0.26.6...v0.26.8

Does this PR introduce a user-facing change?:

Update external huawei cloud controller to 0.26.8

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels May 7, 2024
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 7, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @dabeck. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 7, 2024
@dabeck dabeck force-pushed the feature/huawei-cloud-controller branch from d71b5b0 to a1016b4 Compare May 7, 2024 15:03
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label May 7, 2024
@dabeck dabeck mentioned this pull request May 7, 2024
Open
mzaian
mzaian reviewed May 7, 2024
View reviewed changes
Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 7, 2024
@mzaian
Copy link
Contributor

mzaian commented May 7, 2024

Hello @dabeck

Thanks for the PR. I did not check but did you check to sync https://github.com/kubernetes-sigs/cloud-provider-huaweicloud/blob/v0.26.8/manifests/huawei-cloud-controller-manager-daemonset.yaml with https://github.com/kubernetes-sigs/kubespray/blob/master/roles/kubernetes-apps/external_cloud_controller/huaweicloud/templates/external-huawei-cloud-controller-manager-ds.yml.j2

@dabeck
Copy link
Contributor Author

dabeck commented May 7, 2024

Hello @dabeck

Thanks for the PR. I did not check but did you check to sync https://github.com/kubernetes-sigs/cloud-provider-huaweicloud/blob/v0.26.8/manifests/huawei-cloud-controller-manager-daemonset.yaml with https://github.com/kubernetes-sigs/kubespray/blob/master/roles/kubernetes-apps/external_cloud_controller/huaweicloud/templates/external-huawei-cloud-controller-manager-ds.yml.j2

Good catch - I'll have a look and let you know/update the PR

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 7, 2024
MrFreezeex
MrFreezeex approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dabeck, MrFreezeex, mzaian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0b0faf8 into kubernetes-sigs:master May 8, 2024
60 checks passed
@dabeck dabeck deleted the feature/huawei-cloud-controller branch May 8, 2024 08:54
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@dabeck @pedromcpedro
Update external huawei cloud controller to 0.26.8 (kubernetes-sigs#11172
365ac93 
)

* Update external huawei cloud controller to 0.26.8

* Update huawei cloud controller templates

* Add security-group-id to config

* git fail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzaian mzaian mzaian approved these changes

@MrFreezeex MrFreezeex MrFreezeex approved these changes

@cyclinder cyclinder Awaiting requested review from cyclinder

@yankay yankay Awaiting requested review from yankay

Assignees

@MrFreezeex MrFreezeex

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dabeck @k8s-ci-robot @mzaian @MrFreezeex