Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ubuntu xenial resolv conf #3335

Merged

Conversation

AtzeDeVries
Copy link
Contributor

a PR to fix #3334

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 18, 2018
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 18, 2018
@Atoms
Copy link
Member

Atoms commented Sep 19, 2018

ci check this

@Atoms
Copy link
Member

Atoms commented Sep 21, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 21, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Atoms

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2018
@k8s-ci-robot k8s-ci-robot merged commit 51a5f54 into kubernetes-sigs:master Sep 21, 2018
@KouriR
Copy link

KouriR commented May 10, 2019

Ideally this should check if /run/systemd/resolve/resolv.conf exists first. If not, it should keep using /etc/resolv.conf.

@woopstar
Copy link
Member

you should be able to set the kube_resolv_conf in group vars

@KouriR
Copy link

KouriR commented May 10, 2019

A role var can't be overridden by group vars. I can use extra vars but that's not ideal for me.
P.S. nice avatar

@kowalskey
Copy link

I also concur that this should be configurable. We run ubuntu 18.04 without systemd-resolved and stubled upon inability to override kube_resolv_conf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: DNS does not work with Ubuntu 18.04 / Netplan
6 participants