Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ingress-nginx: Upgrade to 0.21.0 #3789

Merged
merged 1 commit into from
Nov 30, 2018
Merged

ingress-nginx: Upgrade to 0.21.0 #3789

merged 1 commit into from
Nov 30, 2018

Conversation

hswong3i
Copy link
Contributor

Upstream Changes:

Our Changes:

  • Sync templates with upstream changes
  • Remove --default-backend-service requirement. Use the flag only for custom default backends

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 30, 2018
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 30, 2018
@hswong3i
ingress-nginx: Upgrade to 0.21.0
5615974 
Upstream Changes:

  - ingress-nginx 0.21.0 (https://github.com/kubernetes/ingress-nginx/releases/tag/nginx-0.21.0)

Our Changes:

  - Sync templates with upstream changes
  - Remove --default-backend-service requirement. Use the flag only for custom default backends
@riverzhang
Copy link
Contributor

ci check this

@ant31
Copy link
Contributor

ant31 commented Nov 30, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 30, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ant31, hswong3i

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2018
@k8s-ci-robot k8s-ci-robot merged commit deff6a8 into kubernetes-sigs:master Nov 30, 2018
@hswong3i hswong3i deleted the ingress-nginx-0.21.0 branch November 30, 2018 10:56
@aregnier42
Copy link

sorry but why did you remove the creation of the default-backend deployment?
we now get an nginx 404 error page instead of the expected "default backend - 404" message, including when installing the ingress controller with other projects such as kubespray.
thanks

@liuxu623 liuxu623 mentioned this pull request Aug 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Atoms Atoms Awaiting requested review from Atoms

@mirwan mirwan Awaiting requested review from mirwan

Assignees

@ant31 ant31

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hswong3i @riverzhang @ant31 @k8s-ci-robot @aregnier42