Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http proxy support coreos bootstrap script #3885

Closed

Conversation

spaced
Copy link
Contributor

@spaced spaced commented Dec 12, 2018

No description provided.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 12, 2018
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 12, 2018
@spaced
Copy link
Contributor Author

spaced commented Dec 12, 2018

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 12, 2018
@chadswen
Copy link
Member

chadswen commented Jan 3, 2019

ci check this

1 similar comment
@spaced
Copy link
Contributor Author

spaced commented Jan 5, 2019

ci check this

@spaced spaced force-pushed the http_proxy_bootstrap_coreos branch from a6ee2ba to 130555c Compare January 17, 2019 20:01
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: spaced
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ant31

If they are not already assigned, you can assign the PR to them by writing /assign @ant31 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spaced spaced force-pushed the http_proxy_bootstrap_coreos branch from 130555c to 7572cff Compare March 18, 2019 21:49
@spaced spaced force-pushed the http_proxy_bootstrap_coreos branch from c10b9ca to cd6c894 Compare May 1, 2019 22:30
@spaced spaced force-pushed the http_proxy_bootstrap_coreos branch from cd6c894 to c31057e Compare May 21, 2019 13:09
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 21, 2019
@spaced spaced force-pushed the http_proxy_bootstrap_coreos branch from c31057e to c7d515b Compare May 21, 2019 13:11
@spaced spaced force-pushed the http_proxy_bootstrap_coreos branch from c7d515b to 3891c0f Compare May 21, 2019 13:14
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 21, 2019
@spaced
Copy link
Contributor Author

spaced commented May 21, 2019

solved by #4669

@spaced spaced closed this May 21, 2019
@spaced spaced deleted the http_proxy_bootstrap_coreos branch June 10, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants