Correctly execute yum module

[Timoses]

As specified in https://docs.ansible.com/ansible/2.7/modules/yum_module
the 'name' parameter can only be set to "'*'" when the 'state' parameter
is specified as "latest"

Without the "state: latest" option it can happen that ansible freezes: ansible/ansible#51284

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: helpdesk@rt.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[chadswen]

ci check this
/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chadswen, Timoses

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [chadswen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[chadswen]

@Timoses please sign the CNCF CLA, details in the first reply from k8s-ci-robot above.

[Timoses]

@chadswen : Thanks for the hint. I will look into it!

[LuckySB]

Very bad request
This task is called
- name: Update package management cache (YUM)

but with the addition
state: latest
it starts updating all the packages on the server, instead of updating the cache, which is a dangerous behavior

for example:
this task silency upgrade docker from 18.06 to 18.09 on all nodes at the same time.
when restarting the docker on all nodes, the cluster will be unavailable

[Atoms]

/hold

if this really is the case then this job should be reviewed, can we add some locking on newer docker releases (or any other components from yum which could break cluster?)

[Timoses]

See also: ansible/ansible#51284

[Timoses]

CLA signed

[woopstar]

can you fix this task according to @LuckySB's comment, please.

[Timoses]

woopstar wrote:

can you fix this task according to @LuckySB's comment, please.

I'm not sure what exactly LuckySB wants. I am also not very well aware what exactly the yum module does / is supposed to do here.

LuckySB wrote:

Very bad request
This task is called
- name: Update package management cache (YUM)

but with the addition
state: latest
it starts updating all the packages on the server, instead of updating the cache, which is a dangerous behavior

I suppose present is the default behaviour in this case? I will have to test it with my cluster if it works and prevents the freezing when I explicitly set state: present.

for example:
this task silency upgrade docker from 18.06 to 18.09 on all nodes at the same time.
when restarting the docker on all nodes, the cluster will be unavailable
This is actually the exact problem I was experiencing. I did not connect it to the state: latest as without that the task freezes. My workaround was to use yum versionlock..

[Timoses]

if this really is the case then this job should be reviewed, can we add some locking on newer docker releases (or any other components from yum which could break cluster?)

Since I currently have to use state: latest I have the problem that docker is simply updated to latest version. I am currently using yum versionlock to lock down Docker version.

I have triggered further review here: ansible/ansible#51284 (comment)

[Timoses]

With PR #4619 the problematic part has been removed with the statement "it does nothing".

Closing this PR as it

1. disturbed the intention of the task and
2. part has been removed with PR ansible-lint: Fix commands that are also available as module [E303] #4619