Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance ha document #5664

Merged
merged 3 commits into from Feb 22, 2020
Merged

Enhance ha document #5664

merged 3 commits into from Feb 22, 2020

Conversation

keyboardfann
Copy link
Contributor

What type of PR is this?
/kind documentation

What this PR does / why we need it:
The HAproxy config in HA mode document not check master status and exclude the died master, so need to update it.

Which issue(s) this PR fixes:
Fixes #5663

Special notes for your reviewer:
Include test steps on the issue.
#5663

Does this PR introduce a user-facing change?:
NONE

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Feb 20, 2020
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 20, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @keyboardfann!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 20, 2020
@LuckySB
Copy link
Contributor

LuckySB commented Feb 20, 2020

please sign CLA

@keyboardfann
Copy link
Contributor Author

I signed it

@LuckySB
Copy link
Contributor

LuckySB commented Feb 20, 2020

I signed it

Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

@keyboardfann
Copy link
Contributor Author

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 20, 2020
@LuckySB
Copy link
Contributor

LuckySB commented Feb 20, 2020

I signed it

cool, and now please fix markdownlint https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/444495797

@keyboardfann
Copy link
Contributor Author

Hi @LuckySB ,
Thanks for the help. Pass the markdown check and waiting for lgtm.

@LuckySB
Copy link
Contributor

LuckySB commented Feb 22, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: keyboardfann, LuckySB

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2020
@LuckySB
Copy link
Contributor

LuckySB commented Feb 22, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2020
@k8s-ci-robot k8s-ci-robot merged commit b34ec6c into kubernetes-sigs:master Feb 22, 2020
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Mar 7, 2020
* Fix HAproxy config to avoid client offered only unsupported versions error

* Add HAproxy SSL check interval

* Fix ha mode document markdown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HAproxy config don't check and exclude the died master node
3 participants