Fix #6118: Use OS packaging default for apparmor_profile in crio.conf

[jeanfabrice]

What type of PR is this?

/kind bug

What this PR does / why we need it:
While vanilla cri-o makes cri-o is using a cri-default apparmor profile (see https://github.com/cri-o/cri-o/blob/master/docs/crio.conf.5.md), Opensuze Kubic OS packages (the ones used by Kubespray to install cri-o, at least for CentOS, Debian and Ubuntu) install and use a default apparmor profile named 'cri-default-'.

Having the crio.conf file statically configured with apparmor_profile="cri-default" makes cri-o crashes at start since this profile is not installed.

Best option is to not define apparmor_profile in crio.conf and lets cri-o defaults to 'cri-default-<crio-version>'

Which issue(s) this PR fixes:

Fixes #6118

Special notes for your reviewer:`
No clue on how cri-o default apparmor profile is handled on others distributions

Does this PR introduce a user-facing change?:

NONE

[k8s-ci-robot]

Welcome @jeanfabrice!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @jeanfabrice. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[floryut]

@jeanfabrice Thank you for the PR and contribution!
Could you amend your commit message, as the bot said, # and @ are not allowed, the PR number will be added to your commit message and with that the issue link to the pr will be accessible, so need to add it :)

/ok-to-test

[Miouge1]

/approve

Does this mean we will be able to re-introduce some of the crio CI jobs?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeanfabrice, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Miouge1]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[EppO]

/lgtm

one of the CI job didn't report its completion status to GitHub but it passed. I'll try to restart the job. It's not a CRI-O job anyway...