Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Ambassador as an Ingress #6135

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Support for Ambassador as an Ingress #6135

merged 1 commit into from
Jun 24, 2020

Conversation

inercia
Copy link
Contributor

@inercia inercia commented May 13, 2020

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds support for installing Ambassador (https://getambassador.io/) in Kubespray.

Ambassador is installed via the Ambassador Operator which is the recommended way of installed Ambassador - it makes sure users always have the latest version of Ambassador installed and takes care of the update schedule as well.

Does this PR introduce a user-facing change?:

Support for Ambassador OSS as an Ingress Controller when settings `ingress_ambassador_enabled: true`.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 13, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @inercia!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 13, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @inercia. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from EppO and floryut May 13, 2020 19:24
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 13, 2020
@floryut
Copy link
Member

floryut commented May 14, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 14, 2020
@inercia inercia changed the title Support for Ambassador OSS as an Ingress Support for Ambassador as an Ingress May 21, 2020
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 3, 2020
@inercia
Copy link
Contributor Author

inercia commented Jun 3, 2020

@MrFreezeex I think I've addressed your comments. Let me know what you think...

@inercia inercia force-pushed the inercia/ambassador_oss branch 2 times, most recently from 04004c5 to 98e71cb Compare June 9, 2020 11:51
@floryut
Copy link
Member

floryut commented Jun 9, 2020

@inercia Sorry the CI error you got is due to my test reorder commit, you need to rebase master

@inercia inercia force-pushed the inercia/ambassador_oss branch 2 times, most recently from fc5de6d to a3d72a8 Compare June 9, 2020 20:14
@Miouge1
Copy link
Contributor

Miouge1 commented Jun 12, 2020

@inercia thank you for the PR, is there anyone in the datawire team that is a member of the kubernetes or kubernetes-sigs GitHub org? That would allow to set the OWNERS file to allow delegation of patches in the ambassador role.

See GitHub org member requirements

you might also want to se ingress_ambassador_enabled: true in one of the E2E files in tests/files/*.yml

@inercia
Copy link
Contributor Author

inercia commented Jun 15, 2020

@inercia thank you for the PR, is there anyone in the datawire team that is a member of the kubernetes or kubernetes-sigs GitHub org? That would allow to set the OWNERS file to allow delegation of patches in the ambassador role.

@Miouge1, a member of our team, @alexgervais, is member of a kubernetes-sig and he could act as a contact from Datawire.

you might also want to se ingress_ambassador_enabled: true in one of the E2E files in tests/files/*.yml

Ok, I've added it in packet_centos7-calico-ha-once-localhost.yml and packet_centos7-calico-ha.yml.

@inercia inercia force-pushed the inercia/ambassador_oss branch 3 times, most recently from 75bce4a to e4a55bd Compare June 17, 2020 15:00
@inercia
Copy link
Contributor Author

inercia commented Jun 18, 2020

Something seems to be broken now. I'm investigating...

@inercia inercia force-pushed the inercia/ambassador_oss branch 2 times, most recently from 52dd36b to ac62852 Compare June 19, 2020 07:01
@floryut
Copy link
Member

floryut commented Jun 19, 2020

Something seems to be broken now. I'm investigating...

The only CI error left will be fix once you rebase master :)

@inercia
Support for Ambassador OSS as an Ingress
11b1208 
Support for Ambassador OSS as an Ingress Controller when
settings `ingress_ambassador_enabled: true`.

Signed-off-by: Alvaro Saurin <alvaro.saurin@gmail.com>
@inercia
Copy link
Contributor Author

inercia commented Jun 19, 2020

The only CI error left will be fix once you rebase master :)

@floryut I think tests are passing now

@floryut
Copy link
Member

floryut commented Jun 21, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2020
@floryut
Copy link
Member

floryut commented Jun 24, 2020 •
edited
Loading

@LuckySB @Miouge1 If one of you can check & approve this if all good for you, thanks :)

@Miouge1
Copy link
Contributor

Miouge1 commented Jun 24, 2020

OK, sounds good to me, @inercia and @alexgervais good if you can keep this role up to date with future releases of Ambassador.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inercia, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2020
@k8s-ci-robot k8s-ci-robot merged commit 80d16e6 into kubernetes-sigs:master Jun 24, 2020
@inercia
Copy link
Contributor Author

inercia commented Jun 24, 2020

@floryut @MrFreezeex @Miouge1 thanks for your reviews and your time. 🙏

@inercia inercia deleted the inercia/ambassador_oss branch June 24, 2020 15:49
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 29, 2020
@inercia @LuckySB
Support for Ambassador OSS as an Ingress (kubernetes-sigs#6135)
679bd1c 
Support for Ambassador OSS as an Ingress Controller when
settings `ingress_ambassador_enabled: true`.

Signed-off-by: Alvaro Saurin <alvaro.saurin@gmail.com>
@floryut floryut mentioned this pull request Aug 14, 2020
Closed
@floryut
Copy link
Member

floryut commented Sep 24, 2021 •
edited
Loading

@inercia @danielabbatt @aztechian Hey guys, would one of you be able to update ambassador code in kubespray ? I tried to take a look but it's so outdated that the amount of work to understand everything and update it is enormous (at least from my end with no knowledge of the ambassador stack)

If you can't/won't I'll move a PR to deprecate/remove the code in the upcoming releases

@aztechian
Copy link
Contributor

Hi Florian, I can take a look. I suspect there’s not too much to update since the operator shouldn’t change too much.
What prompted you to request it be updated?
I do know there’s a major version change of ambassador coming soon-ish that may require some work here. (but to my knowledge it’s not here yet).

@floryut
Copy link
Member

floryut commented Sep 24, 2021 •
edited
Loading

Hi Florian, I can take a look. I suspect there’s not too much to update since the operator shouldn’t change too much.
What prompted you to request it be updated?
I do know there’s a major version change of ambassador coming soon-ish that may require some work here. (but to my knowledge it’s not here yet).

The main point is that crd are still using v1beta1 which is no longer served by k8s 1.22 (Thus failing the job https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/1618847781)
I could fix the crd pretty easily but my main concerns is that the version is pretty old (more than a year) and I even saw a name change for ambassador ingress (and more than 10 new versions if I'm not mistaken) so I would either keep it up to date or remove it if no one can maintain it
Thanks anyway for the reply @aztechian

@aztechian
Copy link
Contributor

aztechian commented Sep 24, 2021 •
edited
Loading

ah, yes. that makes sense.

FWIW - I think I've traced this down to https://github.com/datawire/ambassador-operator/blob/master/go.mod#L32

@aztechian
Copy link
Contributor

This should be the fix we'd want to track datawire/ambassador-operator#73

@floryut
Copy link
Member

floryut commented Oct 6, 2021

@aztechian Thanks, indeed

@floryut floryut mentioned this pull request Oct 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrFreezeex MrFreezeex MrFreezeex left review comments

@EppO EppO EppO approved these changes

@floryut floryut Awaiting requested review from floryut

Assignees

@floryut floryut

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@inercia @k8s-ci-robot @floryut @Miouge1 @aztechian @EppO @MrFreezeex