Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add snapshot-controller for CSI drivers and snapshot CRDs, add a default volumesnapshotclass when running cinder CSI #6537

Merged
merged 12 commits into from Sep 3, 2020
Merged

Add snapshot-controller for CSI drivers and snapshot CRDs, add a default volumesnapshotclass when running cinder CSI #6537

merged 12 commits into from Sep 3, 2020

Conversation

huxcrux
Copy link
Contributor

@huxcrux huxcrux commented Aug 15, 2020

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
This PR fixes volume snapshots for the Cinder CSI also adds a default volumesnapshotclass.

This fix includes CRDs v1beta1.snapshot.storage.k8s.io and a snapshot controller.
Also a new flag is introduced in the kube ansible module called wait. this module adds "--wait" to the kubectl command when applying manifests.

Which issue(s) this PR fixes:

Fixes N/A

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

* Updated CSI containers to latest version
* Added snapshot-controller (can be used by all CSI drivers)
* Added v1beta1 volumenssnapshot CRDs (can be used by all CSI drivers)
* Added a default volumesnapshotclass for Cinder CSI

@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. labels Aug 15, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @bl0m1. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 15, 2020
@huxcrux
Copy link
Contributor Author

huxcrux commented Aug 17, 2020

/assign @Atoms

@floryut
Copy link
Member

floryut commented Aug 17, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 17, 2020
@Atoms
Copy link
Member

Atoms commented Aug 17, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Aug 27, 2020

This looks great. I've been looking forward to cinder snapshots support in Kubernetes & Kubespray.

@alijahnas any comments on this PR?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 27, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Sep 3, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bl0m1, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2020
@floryut
Copy link
Member

floryut commented Sep 3, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2020
@floryut floryut mentioned this pull request Sep 3, 2020
Closed
@k8s-ci-robot k8s-ci-robot merged commit 2ff7ab8 into kubernetes-sigs:master Sep 3, 2020
erulabs added a commit to kubesail/kubespray that referenced this pull request Sep 12, 2020
@erulabs
Merge branch 'master' of https://github.com/kubernetes-sigs/kubespray
d158807 
* 'master' of https://github.com/kubernetes-sigs/kubespray:
  Add protectKernelDefaults option (default true) to kubelet config file (kubernetes-sigs#6611)
  Rotate kubelet server certificate. (kubernetes-sigs#6453)
  Add snapshot-controller for CSI drivers and snapshot CRDs, add a default volumesnapshotclass when running cinder CSI (kubernetes-sigs#6537)
  Calico: update crds to v1 and cr (kubernetes-sigs#6360)
  Fix E306 in roles/network_plugin (kubernetes-sigs#6516)
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jan 15, 2021
@LuckySB
Add snapshot-controller for CSI drivers and snapshot CRDs, add a defa…
9a68783 
…ult volumesnapshotclass when running cinder CSI (kubernetes-sigs#6537)

* add snapshot-controller and v1beta1 snapshot api

* fix typo

* udpate manifest to v1beta1

* update

* update manifests

* fix spelling

* wait until crd is applied

* fix missing info in kube module

* revert snapshotclass

* add snapshot crds before applying the csi driver

* add crds, missed them in last commit

* use pull policy from kubespray
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Miouge1 Miouge1 Miouge1 left review comments

@floryut floryut floryut approved these changes

@LuckySB LuckySB Awaiting requested review from LuckySB

Assignees

@Atoms Atoms

@floryut floryut

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@huxcrux @k8s-ci-robot @floryut @Atoms @Miouge1