Add RHEL support subscription registration

[bmelbourne]

What type of PR is this?
/kind feature

What this PR does / why we need it:
The new Red Hat support subscription registration feature will allow developers and administrators to deploy Kubespray across RHEL 7/8 hosts using Red Hat support account credentials, or an Organization ID/Activation Key combination.

A valid Red Hat support subscription is required to download packages from the RHEL 7/8 repositories via yum or dnf.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[k8s-ci-robot]

Hi @bmelbourne. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[floryut]

You know that you don't have to close the PR at all, you can delete the branch locally, change everything you want, force push and the PR will be updated 😄
Anyway.

/ok-to-test

[bmelbourne]

You know that you don't have to close the PR at all, you can delete the branch locally, change everything you want, force push and the PR will be updated 😄
Anyway.

/ok-to-test

Thanks for the advice @floryut

As I start creating these initial PRs, I'm on a steep learning curve when it comes to working with upstream repos and forked local repos. I'm getting to know what options are available when things get stuck in the CI tests.

[bmelbourne]

/assign @mattymo

[bmelbourne]

@mattymo
All of the CI tests are now passing.

[floryut]

@bmelbourne why are you force pushing and repushing pretty much the same changes ? except overloading the CI 🤔

[bmelbourne]

@bmelbourne why are you force pushing and repushing pretty much the same changes ? except overloading the CI 🤔

I'm just keeping the PR up-to-date with the latest master commits ready for the review (checking for any merge conflicts), as this is what I've been asked to do prior to any review being started 🤔

I'm happy to stop doing it if reviewers don't require a rebase.

[floryut]

@bmelbourne why are you force pushing and repushing pretty much the same changes ? except overloading the CI 🤔

I'm just keeping the PR up-to-date with the latest master commits ready for the review (checking for any merge conflicts), as this is what I've been asked to do prior to any review being started 🤔

I'm happy to stop doing it if reviewers don't require a rebase.

Please don't 😄
As long as the PR don't have any conflict/merge issues (Github auto detect that and put a flag need-rebase if so) you are good to go

[EppO]

we have no way to test this in the CI though... any RH subscription to spare, anyone?? :)

[bmelbourne]

we have no way to test this in the CI though... any RH subscription to spare, anyone?? :)

@EppO
It's possible to create a Red Hat Developer's account which will provide a 1-year support subscription, this could then used by the CI pipeline temporarily. As a more permanent solution, we could reach out to our Red Hat Kubernetes network and ask them to set-up a non-expiring support account subscription for Kubespray CI??

After all this does benefit Red Hat organisation in that users will have reassurance that Kubespray has been tested and deployed on RHEL 7/8 machines.

[floryut]

we have no way to test this in the CI though... any RH subscription to spare, anyone?? :)

@EppO
It's possible to create a Red Hat Developer's account which will provide a 1-year support subscription, this could then used by the CI pipeline temporarily. As a more permanent solution, we could reach out to our Red Hat Kubernetes network and ask them to set-up a non-expiring support account subscription for Kubespray CI??

After all this does benefit Red Hat organisation in that users will have reassurance that Kubespray has been tested and deployed on RHEL 7/8 machines.

Yup even the CNCF might help us with that (as we are under their umbrella)

[EppO]

in the meantime, I don't see any reasons not to merge this

/lgtm

[Miouge1]

I have mixed thoughts about this PR.

On one hand I understand that a registration is required to download packages than we need for Kubespray.

On the other hand, a bunch of other things are also required to download packages: IP configuration, DNS, etc... things which we take for granted or are just requirements.

What do you think?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmelbourne, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Miouge1]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bmelbourne]

/retest

[floryut]

As this was approved and lgtmed, let's merge

/lgtm