Added support for dynamic tags in AWS and Azure. #6752

gutek9 · 2020-09-25T13:16:19Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

Support for dynamic tags in AWS and Azure.

Which issue(s) this PR fixes:

Fixes #6751

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

k8s-ci-robot · 2020-09-25T13:16:22Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2020-09-25T13:16:26Z

Welcome @gutek9!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2020-09-25T13:16:27Z

Hi @gutek9. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

floryut · 2020-09-25T13:18:58Z

@gutek9 Thank you for the PR, could you please sign CLA ?

floryut · 2020-09-25T13:22:12Z

Any way to add some sample in azure.yml/aws.yml and/or in documentation ?
Otherwise hard for new users to find that.

/ok-to-test

gutek9 · 2020-09-25T13:38:49Z

@gutek9 Thank you for the PR, could you please sign CLA ?

Done.

gutek9 · 2020-09-25T13:43:31Z

Any way to add some sample in azure.yml/aws.yml and/or in documentation ?
Otherwise hard for new users to find that.

/ok-to-test

Added examples in aws.yml/azure.yml

EppO · 2020-09-25T15:14:37Z

/lgtm

oomichi

/cc @oomichi

oomichi · 2020-09-25T16:35:08Z

roles/kubernetes-apps/csi_driver/aws_ebs/templates/aws-ebs-csi-controllerservice.yml.j2

@@ -25,6 +25,9 @@ spec:
          image: {{ aws_ebs_csi_plugin_image_repo }}:{{ aws_ebs_csi_plugin_image_tag }}
          args:
            - --endpoint=$(CSI_ENDPOINT)
+{% if aws_ebs_csi_extra_volume_tags is defined %}
+            - --extra-volume-tags={{ aws_ebs_csi_extra_volume_tags }}


lgtm since https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/cmd/options/controller_options.go#L36

oomichi · 2020-09-25T16:43:40Z

roles/kubernetes-apps/persistent_volumes/azuredisk-csi/templates/azure-csi-storage-class.yml.j2

@@ -6,6 +6,9 @@ metadata:
 provisioner: disk.csi.azure.com
 parameters:
  skuname: {{ storage_account_type }}
+{% if azure_csi_tags is defined %}
+  tags: {{ azure_csi_tags }}


I cannot find why this parameter adds the specified tags to the provisioned volumes.
Could you show that?

Documentation: https://github.com/kubernetes-sigs/azuredisk-csi-driver/blob/master/docs/driver-parameters.md
Code: https://github.com/kubernetes-sigs/azuredisk-csi-driver/blob/523f08e0aa159d295f3e2abb51cc88dc05b88e00/vendor/k8s.io/legacy-cloud-providers/azure/azure_managedDiskController.go#L95

Seems good, agreed @oomichi?

Thanks for your explanation @gutek9 !
That is good for me :-)

/lgtm

gutek9 · 2020-09-26T10:44:42Z

@floryut sorry, misclick :-(

floryut · 2020-09-26T17:47:37Z

/approve

k8s-ci-robot · 2020-09-26T17:47:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, gutek9

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* Added support for dynamic tags in AWS and Azure. * Added examples of dynamic tags configuration.

Added support for dynamic tags in AWS and Azure.

7043063

k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 25, 2020

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 25, 2020

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 25, 2020

k8s-ci-robot requested review from alijahnas and holmsten September 25, 2020 13:16

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 25, 2020

gutek9 mentioned this pull request Sep 25, 2020

Tagging resources dynamically created by Kubernetes #6751

Closed

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 25, 2020

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 25, 2020

Added examples of dynamic tags configuration.

6493684

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 25, 2020

k8s-ci-robot assigned EppO Sep 25, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2020

oomichi reviewed Sep 25, 2020

View reviewed changes

k8s-ci-robot requested a review from oomichi September 25, 2020 16:43

k8s-ci-robot assigned oomichi Sep 25, 2020

gutek9 requested a review from floryut September 26, 2020 10:40

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2020

k8s-ci-robot merged commit aba63f0 into kubernetes-sigs:master Sep 26, 2020

gutek9 deleted the dynamic-tags-support branch October 6, 2020 18:35

floryut mentioned this pull request Dec 19, 2020

Release Proposal v2.15 #7069

Closed

LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jan 16, 2021

Added support for dynamic tags in AWS and Azure. (kubernetes-sigs#6752)

7b93372

* Added support for dynamic tags in AWS and Azure. * Added examples of dynamic tags configuration.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added support for dynamic tags in AWS and Azure. #6752

Added support for dynamic tags in AWS and Azure. #6752

gutek9 commented Sep 25, 2020 •

edited

k8s-ci-robot commented Sep 25, 2020

k8s-ci-robot commented Sep 25, 2020

k8s-ci-robot commented Sep 25, 2020

floryut commented Sep 25, 2020

floryut commented Sep 25, 2020

gutek9 commented Sep 25, 2020

gutek9 commented Sep 25, 2020

EppO commented Sep 25, 2020

oomichi left a comment

oomichi Sep 25, 2020

oomichi Sep 25, 2020

gutek9 Sep 25, 2020 •

edited

floryut Sep 25, 2020

oomichi Sep 25, 2020

gutek9 Sep 26, 2020

gutek9 commented Sep 26, 2020

floryut commented Sep 26, 2020

k8s-ci-robot commented Sep 26, 2020

Added support for dynamic tags in AWS and Azure. #6752

Added support for dynamic tags in AWS and Azure. #6752

Conversation

gutek9 commented Sep 25, 2020 • edited

k8s-ci-robot commented Sep 25, 2020

k8s-ci-robot commented Sep 25, 2020

k8s-ci-robot commented Sep 25, 2020

floryut commented Sep 25, 2020

floryut commented Sep 25, 2020

gutek9 commented Sep 25, 2020

gutek9 commented Sep 25, 2020

EppO commented Sep 25, 2020

oomichi left a comment

Choose a reason for hiding this comment

oomichi Sep 25, 2020

Choose a reason for hiding this comment

oomichi Sep 25, 2020

Choose a reason for hiding this comment

gutek9 Sep 25, 2020 • edited

Choose a reason for hiding this comment

floryut Sep 25, 2020

Choose a reason for hiding this comment

oomichi Sep 25, 2020

Choose a reason for hiding this comment

gutek9 Sep 26, 2020

Choose a reason for hiding this comment

gutek9 commented Sep 26, 2020

floryut commented Sep 26, 2020

k8s-ci-robot commented Sep 26, 2020

gutek9 commented Sep 25, 2020 •

edited

gutek9 Sep 25, 2020 •

edited