Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dual stack IPv4 & IPv6 networking #6859

Merged
merged 6 commits into from
Feb 5, 2021
Merged

Support dual stack IPv4 & IPv6 networking #6859

merged 6 commits into from
Feb 5, 2021

Conversation

miff2000
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

This adds functionality to Kubespray to support dual stack deployments (IPv4 & IPv6 combined)

Which issue(s) this PR fixes:

Fixes #6791

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Support for dual stack (IPv4 & IPv6) network deployment using Calico is introduced as an opt-in feature.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 26, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @miff2000. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 26, 2020
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 26, 2020
@k8s-ci-robot
Copy link
Contributor

@miff2000: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@miff2000
Copy link
Contributor Author

@holmsten, would you be able to take a look this PR please?

@EppO
Copy link
Contributor

EppO commented Oct 28, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 28, 2020
@miff2000
Copy link
Contributor Author

Hey guys, is anyone able to give this a review or merge into a release? @ant31, @EppO are you able to help?

@LuckySB
Copy link
Contributor

LuckySB commented Oct 31, 2020

  1. It is necessary to check the choice of CNI Calico when enable_dual_stack_networks: true
    Please add asserts task to preinstall role 0020-verify-settings

  2. Tests are needed. I suggest adding enable_dual_stack_networks: true to at least one of the tests packet_centos7-calico-ha

Copy link
Contributor Author

@miff2000 miff2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a side note, to use dual stack networking, you need to have this set:

kube_feature_gates:
  - IPv6DualStack=true

Do you think I should just add a node into the documentation, or try and set them automatically for the user, working with the #6851 changes?

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 2, 2020
@miff2000 miff2000 changed the base branch from release-2.14 to master November 2, 2020 19:36
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 2, 2020
@miff2000 miff2000 marked this pull request as draft November 2, 2020 20:57
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 2, 2020
Vagrantfile Show resolved Hide resolved
Vagrantfile Show resolved Hide resolved
@champtar
Copy link
Contributor

Do we want to set /label tide/merge-method-rebase ? (rebase instead of squash)

@miff2000
Copy link
Contributor Author

Do we want to set /label tide/merge-method-rebase ? (rebase instead of squash)

Sure! I didn't know that was a thing, but would usually prefer a rebase too. Can I do that myself?

@champtar
Copy link
Contributor

Yes

@miff2000
Copy link
Contributor Author

/label tide/merge-method-rebase

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges. label Jan 27, 2021
@k8s-ci-robot
Copy link
Contributor

@miff2000: The /retest command does not accept any targets.
The following commands are available to trigger jobs:

  • /test pull-kubespray-yamllint

Use /test all to run all jobs.

In response to this:

/retest vagrant_ubuntu18-flannel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 2, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 2, 2021
@miff2000
Copy link
Contributor Author

miff2000 commented Feb 4, 2021

Are we ready for an LGTM now do you think?
@EppO @LuckySB

@EppO
Copy link
Contributor

EppO commented Feb 4, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2021
@oomichi
Copy link
Contributor

oomichi commented Feb 5, 2021

/lgtm

Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Really good work @miff2000 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, miff2000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2021
@k8s-ci-robot k8s-ci-robot merged commit c2c97c3 into kubernetes-sigs:master Feb 5, 2021
@floryut floryut mentioned this pull request May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for dual-stack (IPv4 and IPv6) networking
10 participants