-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configuring container log limits for Kubelet #6933
Allow configuring container log limits for Kubelet #6933
Conversation
Hi @basvandenbrink. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @chadswen |
kubelet_logfiles_max_nr: 5 | ||
|
||
# Maximum size of the container log file before it is rotated | ||
kubelet_logfiles_max_size: 10Mi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10Mi is really small. Can it be 50Mi by default? Docker by default uses 100mb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, this is actually Kubelet's default value at 10Mi. No objections.
/lgtm |
@basvandenbrink now that #6910 is merged, could you please rebase master ? Thank you! |
78c017c
to
41c8843
Compare
Did a merge instead of a rebase. Fixed it and force pushed the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
As this was already lgtm-ed
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: basvandenbrink, floryut, mattymo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
What type of PR is this?
What this PR does / why we need it:
So we can finetune the rotation behaviour of Kubelet.
Which issue(s) this PR fixes:
Fixes #6932
Special notes for your reviewer:
Does this PR introduce a user-facing change?: