Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calico: update files to handle multi-asn bgp peering conditions. #6971

Merged
merged 7 commits into from
Dec 18, 2020

Conversation

catblade
Copy link
Contributor

@catblade catblade commented Nov 30, 2020

What type of PR is this?
/kind bug

What this PR does / why we need it:
Without these changes, multi-ASN configs will not work.

  • Add in ability for kubespray to configure ASNs according to routers being peered with by the node instead of relying on the user to put in local_as for every single node.
  • Add in option to have BGP configured so that we can choose to not have a global ASN. With multiple ASNs, will not work.

Tested on our little cluster with a switch. Do not see infrastructure in kubepsray proper to test this type of config (needs switch configuration to test). We have an iperf test that works with these changes.

Which issue(s) this PR fixes:

Fixes #
#6845

Special notes for your reviewer:
You may wish to talk to me directly in how to set a switch for testing.

Does this PR introduce a user-facing change?
Yes.

New item in samples shows you can choose not to set a global calico ASN, option named calico_no_global_as_num
No longer need to set local_as per-node. It will pull it in from the tors as they are defined by node. This will make changing servers between racks (or otherwise configuring) less prone to user error.

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 30, 2020
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 30, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @catblade. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 30, 2020
@catblade catblade changed the title update files to handle multi-asn bgp peering conditions. Calico: update files to handle multi-asn bgp peering conditions. Nov 30, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 30, 2020
@catblade
Copy link
Contributor Author

catblade commented Dec 1, 2020

@mirwan

roles/network_plugin/calico/tasks/install.yml Outdated Show resolved Hide resolved
roles/network_plugin/calico/tasks/install.yml Outdated Show resolved Hide resolved
roles/network_plugin/calico/tasks/install.yml Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 9, 2020
@mirwan mirwan self-requested a review December 12, 2020 08:10
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: catblade, mirwan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2020
@mirwan
Copy link
Contributor

mirwan commented Dec 12, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 12, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 12, 2020
@mirwan
Copy link
Contributor

mirwan commented Dec 18, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit 10a6bd6 into kubernetes-sigs:master Dec 18, 2020
@floryut floryut mentioned this pull request Dec 19, 2020
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jan 17, 2021
…ernetes-sigs#6971)

* update files to handle multi-asn bgp peering conditions.

* put back in the serviceClusterIPs.  Bad merge.

* remove extraneous environment var.

* update files as discussed with mirwan

* update titles.

* add not in.

* add a conditional for using bgp to advertise cluster ips.

Co-authored-by: marlow-h <mweston@habana.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants