Add ping_access_ip to control ping test

[cristiklein]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

In some environments, it might not be possible to ping the IP address
of the nodes, e.g., because ICMP echo is blocked.

This commit allows kubespray to be configured to disable the ping
check, while performing all other checks.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Added the `ping_access_ip` variable to enable/disable ping test during preinstall. By default ping testing is enabled to preserve previous behavior.

[k8s-ci-robot]

Welcome @cristiklein!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @cristiklein. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[champtar]

Why not do an ansible ping ? https://docs.ansible.com/ansible/latest/collections/ansible/builtin/ping_module.html

[cristiklein]

@champtar I wasn't sure what was the original intent of the ping test. I assume people rely on it, so I wanted my change to be backwards-compatible. Doing an "ansible ping" test could be an interesting addition to the preinstalll test, but that feels like a different PR to me.

[floryut]

@champtar I wasn't sure what was the original intent of the ping test. I assume people rely on it, so I wanted my change to be backwards-compatible. Doing an "ansible ping" test could be an interesting addition to the preinstalll test, but that feels like a different PR to me.

Anyway you need to rebase master to fix the CI error you have 👍

[cristiklein]

@floryut I rebased this onto master.

[cristiklein]

Rebased to today's master

/assign @chadswen

[floryut]

/approve
/ok-to-test
/cc @oomichi @EppO

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristiklein, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[LuckySB]

I do not understand why СI ended without errors
you added a variable, but did not specify its default value in role

[floryut]

I do not understand why СI ended without errors
you added a variable, but did not specify its default value in role

@LuckySB what do you mean ? CI is green, or did I miss something ?

[LuckySB]

well, access_ip is optional variable
and not defined in our CI tasks, so this check is not work, because

  when:
    - access_ip is defined

[LuckySB]

please set default value for var
and I think it is better to name the variable
ping_access_ip
with default value 'true'

[LuckySB]

/lgtm