Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manage-offline-container-images.sh #7024

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

oomichi
Copy link
Contributor

@oomichi oomichi commented Dec 11, 2020

What type of PR is this?

/kind feature

What this PR does / why we need it:

One challenge of offline deployment was how to collect necessary container images as a preparation.
This adds a script to solve it.
Kubespray has the option registry_enabled to deploy container registry locally, but we cannot use it for this case because we need to deploy container registry before Kubernetes deployment but the option requires Kubernetes deployment in advance.

Does this PR introduce a user-facing change?:

Add manage-offline-container-images.sh to collect necessary container images and register the images to local registry.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 11, 2020
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 11, 2020
@oomichi
Copy link
Contributor Author

oomichi commented Dec 14, 2020

/retest

One challenge of offline deployment was how to collect necessary
container images as a preparation. This adds a script to solve it.
@oomichi oomichi changed the title Add manage-offline-container-images.sh WIP: Add manage-offline-container-images.sh Dec 17, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 17, 2020
@oomichi
Copy link
Contributor Author

oomichi commented Dec 17, 2020

Kubespray contains a role for deploying a local container registry.
It is better to use it.

@oomichi oomichi changed the title WIP: Add manage-offline-container-images.sh Add manage-offline-container-images.sh Dec 17, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 17, 2020
@oomichi
Copy link
Contributor Author

oomichi commented Dec 17, 2020

Kubespray contains a role for deploying a local container registry.

Kubespray has the option registry_enabled to deploy container registry locally, but we cannot use it for this case because we need to deploy container registry before Kubernetes deployment but the option requires Kubernetes deployment in advance.

@floryut
Copy link
Member

floryut commented Dec 21, 2020

@oomichi Did you check #6766 ? As it's quite stale, maybe try to include some of it, WDYT ?

@oomichi
Copy link
Contributor Author

oomichi commented Dec 21, 2020

@floryut
Thanks for your comment. I reviewed the other PR.

@floryut
Copy link
Member

floryut commented Jan 5, 2021

@floryut
Thanks for your comment. I reviewed the other PR.

Are you finish in this one?
I was thinking about merging or cherry picking the other one if anything is interesting otherwise I'm fine to merge this one as it is.

Up to you @oomichi :)

@oomichi
Copy link
Contributor Author

oomichi commented Jan 5, 2021

@floryut
Thanks for your comment. I reviewed the other PR.

Are you finish in this one?
I was thinking about merging or cherry picking the other one if anything is interesting otherwise I'm fine to merge this one as it is.

Up to you @oomichi :)

Yes, I finished this PR work already :-)
I have confirmed this PR script works fine on my environment, and I'd like to share the script to get more feedback to improve it in the community.

At this time, I cannot get replies related to my review points on the other PR yet.
It is a nice idea to bring good features from the other one after getting replies based on this.

@floryut
Copy link
Member

floryut commented Jan 6, 2021

/cc @EppO
Could you check and lgtm if ok for you ?

@floryut
Copy link
Member

floryut commented Jan 6, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2021
@floryut floryut added this to the 2.15 milestone Jan 6, 2021
@EppO
Copy link
Contributor

EppO commented Jan 6, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2021
@k8s-ci-robot k8s-ci-robot merged commit ad244ab into kubernetes-sigs:master Jan 6, 2021
@floryut floryut mentioned this pull request Jan 6, 2021
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jan 17, 2021
One challenge of offline deployment was how to collect necessary
container images as a preparation. This adds a script to solve it.
@oomichi oomichi deleted the add-offline-tool branch March 2, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants