Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding other masters sequentially, not in parallel #7166

Merged
merged 1 commit into from
Jan 16, 2021

Conversation

LuckySB
Copy link
Contributor

@LuckySB LuckySB commented Jan 15, 2021

/kind bug
/kind feature

What this PR does / why we need it:

Sometimes, when installing 3 masters, kubeadm crashed with an error, because the second and third masters were added at the same time.

Ansible 2.9 has a wonderful instruction that allows you to execute a specific task sequentially on all hosts

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. labels Jan 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LuckySB

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 15, 2021
@oomichi
Copy link
Contributor

oomichi commented Jan 16, 2021

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit b2995e4 into kubernetes-sigs:master Jan 16, 2021
LuckySB added a commit to southbridgeio/kubespray that referenced this pull request Feb 2, 2021
champtar pushed a commit to champtar/kubespray that referenced this pull request Feb 17, 2021
k8s-ci-robot pushed a commit that referenced this pull request Feb 22, 2021
@floryut floryut mentioned this pull request May 11, 2021
zexi pushed a commit to zexi/kubespray that referenced this pull request Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants