Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote node.k8s.io API groups from v1beta1 to v1 #7182

Merged
merged 1 commit into from Jan 19, 2021
Merged

Promote node.k8s.io API groups from v1beta1 to v1 #7182

merged 1 commit into from Jan 19, 2021

Conversation

floryut
Copy link
Member

@floryut floryut commented Jan 18, 2021 •
edited

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Remove bunch of deprecated API:

Which issue(s) this PR fixes:
none

Special notes for your reviewer:
3 commits for all 3 changes

Does this PR introduce a user-facing change?:

`kube_apiserver_insecure_port` and `kube_apiserver_insecure_bind_address` have been removed as those parameters are no longer supported by Kubernetes

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 18, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2021
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 18, 2021
@floryut floryut changed the title Deprecated 1.20 Cleanup a bunch of deprecated things wth k8s 1.20 Jan 18, 2021
@dougsland
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@dougsland: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@floryut floryut force-pushed the deprecated_1.20 branch 2 times, most recently from 8af635d to adf3903 Compare January 19, 2021 08:26
@floryut
Copy link
Member Author

floryut commented Jan 19, 2021

/label tide/merge-method-rebase

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges. label Jan 19, 2021
LuckySB
LuckySB suggested changes Jan 19, 2021
View reviewed changes
roles/kubernetes/master/templates/kubeadm-config.v1beta2.yaml.j2 Outdated Show resolved Hide resolved
roles/kubernetes/preinstall/tasks/0020-verify-settings.yml Outdated
@@ -130,11 +130,11 @@
- cloud_provider is defined and cloud_provider == "oci"
- not ignore_assert_errors

- name: Stop if RBAC and anonymous-auth are not enabled when insecure port is disabled
- name: Stop if RBAC and anonymous-auth are not enabled
assert:
that: rbac_enabled and kube_api_anonymous_auth
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we require that ? kube_api_anonymous_auth == true ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hum, legacy thing that can be removed I guess

@LuckySB
Copy link
Contributor

LuckySB commented Jan 19, 2021

I think it is too early to remove the option insecure_port
we must wait until version 1.19 becomes EOL, and only then delete

@floryut
Copy link
Member Author

floryut commented Jan 19, 2021

I think it is too early to remove the option insecure_port
we must wait until version 1.19 becomes EOL, and only then delete

Ok I'll keep that in mind and will only change the runtime class for newer k8s version in this PR

@floryut floryut changed the title Cleanup a bunch of deprecated things wth k8s 1.20 Promote node.k8s.io API groups from v1beta1 to v1 Jan 19, 2021
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 19, 2021
@LuckySB
Copy link
Contributor

LuckySB commented Jan 19, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 19, 2021
@k8s-ci-robot k8s-ci-robot merged commit 9a75501 into kubernetes-sigs:master Jan 19, 2021
@LuckySB LuckySB mentioned this pull request Feb 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuckySB LuckySB LuckySB requested changes

@EppO EppO Awaiting requested review from EppO

@holmsten holmsten Awaiting requested review from holmsten

Assignees

@LuckySB LuckySB

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@floryut @k8s-ci-robot @dougsland @LuckySB