FIX: Bastion undefined variable #7227

breuerfelix · 2021-01-28T10:17:26Z

/kind bug

What this PR does / why we need it:
Fixes the following error when using Bastion Node with the sample config.

Which issue(s) this PR fixes:

fatal: [bastion]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'dict object' has no attribute 'bastion'\n\nThe error appears to be in '..../kubespray/roles/bastion-ssh-config/tasks/main.yml': line 2, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n---\n- name: set bastion host IP\n  ^ here\n"}

Does this PR introduce a user-facing change?:

NONE

Fixes the following error when using Bastion Node with the sample config. ``` fatal: [bastion]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'dict object' has no attribute 'bastion'\n\nThe error appears to be in '/home/felix/inovex/kubespray/roles/bastion-ssh-config/tasks/main.yml': line 2, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n---\n- name: set bastion host IP\n ^ here\n"} ```

k8s-ci-robot · 2021-01-28T10:17:29Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2021-01-28T10:17:34Z

Welcome @breuerfelix!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2021-01-28T10:17:34Z

Hi @breuerfelix. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

floryut

~~@breuerfelix Thank you for the PR, could you please sign CLA ?~~ all good 👍

/ok-to-test
/approve

k8s-ci-robot · 2021-01-28T10:27:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: breuerfelix, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

oomichi · 2021-01-28T18:06:01Z

Thanks for doing this.

/lgtm

Fixes the following error when using Bastion Node with the sample config. ``` fatal: [bastion]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'dict object' has no attribute 'bastion'\n\nThe error appears to be in '/home/felix/inovex/kubespray/roles/bastion-ssh-config/tasks/main.yml': line 2, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n---\n- name: set bastion host IP\n ^ here\n"} ```

Fixes the following error when using Bastion Node with the sample config. ``` fatal: [bastion]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'dict object' has no attribute 'bastion'\n\nThe error appears to be in '/home/felix/inovex/kubespray/roles/bastion-ssh-config/tasks/main.yml': line 2, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n---\n- name: set bastion host IP\n ^ here\n"} ``` (cherry picked from commit 973628f)

k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 28, 2021

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 28, 2021

k8s-ci-robot requested review from bozzo and holmsten January 28, 2021 10:17

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 28, 2021

floryut approved these changes Jan 28, 2021

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2021

k8s-ci-robot assigned oomichi Jan 28, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2021

k8s-ci-robot merged commit 973628f into kubernetes-sigs:master Jan 28, 2021

floryut mentioned this pull request May 11, 2021

Release Proposal v2.16 #7602

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FIX: Bastion undefined variable #7227

FIX: Bastion undefined variable #7227

breuerfelix commented Jan 28, 2021 •

edited

Loading

k8s-ci-robot commented Jan 28, 2021

k8s-ci-robot commented Jan 28, 2021

k8s-ci-robot commented Jan 28, 2021

floryut left a comment •

edited

Loading

k8s-ci-robot commented Jan 28, 2021

oomichi commented Jan 28, 2021

FIX: Bastion undefined variable #7227

FIX: Bastion undefined variable #7227

Conversation

breuerfelix commented Jan 28, 2021 • edited Loading

k8s-ci-robot commented Jan 28, 2021

k8s-ci-robot commented Jan 28, 2021

k8s-ci-robot commented Jan 28, 2021

floryut left a comment • edited Loading

Choose a reason for hiding this comment

k8s-ci-robot commented Jan 28, 2021

oomichi commented Jan 28, 2021

breuerfelix commented Jan 28, 2021 •

edited

Loading

floryut left a comment •

edited

Loading