Refactor cilium_ipsec_enabled check #7520
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
Hi @fritchie. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/XS
| - {name: cilium, file: cilium-ds.yml, type: ds} | ||
| - {name: cilium, file: cilium-deploy.yml, type: deploy} | ||
| - {name: cilium, file: cilium-sa.yml, type: sa} | ||
| register: cilium_node_manifests | ||
| when: | ||
| - inventory_hostname in groups['kube_control_plane'] | ||
| - item.file != "cilium-secret.yml" or (item.file == "cilium-secret.yml" and cilium_ipsec_enabled) | ||
| - inventory_hostname in groups['kube_control_plane'] and item.when | default(True) | bool |
There was a problem hiding this comment.
The and should be replaced by 2 lines I think
There was a problem hiding this comment.
change made and tested
This is a followup to #7413 Although the code worked there was a desire for a better solution. Hopefully people will be happy with this alternative.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, fritchie The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
* Upgrade cilium roles * Del old test result * Add hubble ui examples * Refactor hubble metrics * Markdown fix pipeline errors * yamllint check and fix * refactor install from #7520 * Docs syntax change (fix) * Cilium set default 1.8.9 * Update cilium version in Readme
This is a followup to kubernetes-sigs#7413 Although the code worked there was a desire for a better solution. Hopefully people will be happy with this alternative.
* Upgrade cilium roles * Del old test result * Add hubble ui examples * Refactor hubble metrics * Markdown fix pipeline errors * yamllint check and fix * refactor install from kubernetes-sigs#7520 * Docs syntax change (fix) * Cilium set default 1.8.9 * Update cilium version in Readme
This is a followup to kubernetes-sigs#7413 Although the code worked there was a desire for a better solution. Hopefully people will be happy with this alternative.
* Upgrade cilium roles * Del old test result * Add hubble ui examples * Refactor hubble metrics * Markdown fix pipeline errors * yamllint check and fix * refactor install from kubernetes-sigs#7520 * Docs syntax change (fix) * Cilium set default 1.8.9 * Update cilium version in Readme
This is a followup to
#7413
Although the code worked there was a desire for a better solution.
Hopefully people will be ok with this alternative.