-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for configuring cri-o pids_limit #7525
add support for configuring cri-o pids_limit #7525
Conversation
Hi @cristicalin. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
8fe6106
to
0bbd2c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cristicalin Don't forget to fix the md issue
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cristicalin, floryut The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@floryut which md issue do you have in mind? |
0bbd2c5
to
fdf5704
Compare
I updated the md with a different link format and a bit more detail on the ansible group but I'm not sure this is what you were referring to. |
I was indeed referring to the link, and good for the added details 👍 thanks |
/ok-to-test |
What type of PR is this?
What this PR does / why we need it:
This PR introduces a way to override cri-o
pids_limit
which is currently hardcoded to 1024.Which issue(s) this PR fixes:
Fixes #7511
Special notes for your reviewer:
Does this PR introduce a user-facing change?: