Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ppc64le support #8505

Merged
merged 2 commits into from
Feb 4, 2022
Merged

Conversation

mgiessing
Copy link
Contributor

@mgiessing mgiessing commented Feb 3, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:
This PR adds support for ppc64le architecture. Therefore the relevant checksums have been added accordingly.
At the moment this does only work with container_manager set to docker as there is no ppc64le release for the default value containerd. Tested it on RHEL/CentOS.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add ppc64le support

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 3, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 3, 2022

CLA Signed

The committers are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 3, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @mgiessing!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @mgiessing. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 3, 2022
@oomichi
Copy link
Contributor

oomichi commented Feb 4, 2022

Nice work, thanks for doing this.
Could you update Does this PR introduce a user-facing change?: for Add ppc64le support.

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 4, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2022
@floryut
Copy link
Member

floryut commented Feb 4, 2022

/release-note-edit Add ppc64le support

@floryut
Copy link
Member

floryut commented Feb 4, 2022

/release-note-edit Add ppc64le support

kubernetes/test-infra#23473 ~~nicely not working 🤷

Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgiessing Not sure how many people need this but thanks 🙇

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, mgiessing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2022
@k8s-ci-robot k8s-ci-robot merged commit 6a4fd33 into kubernetes-sigs:master Feb 4, 2022
@mgiessing
Copy link
Contributor Author

@floryut Probably not as many as for x86, but it definately helps 🙌
Thanks for reviewing & merging - if there are issues related to Kubespray on ppc64le arch feel free to @ me there!

@mgiessing
Copy link
Contributor Author

@floryut Just for my understanding (and let me say I'm not very experienced with a "general" releasing process at all):
What does it take that this PR makes it into a release?

I thought all approved PRs will basically make it into the next release, but that seems not to be the case. I just found out v2.18.1 still supports only i386, x86 & arm which means ppc64le users need to work on the master/main branch and that can sometimes be troublesome.
Hope you can enlighten me here 😅 - Thanks!

@floryut
Copy link
Member

floryut commented Apr 11, 2022

@floryut Just for my understanding (and let me say I'm not very experienced with a "general" releasing process at all): What does it take that this PR makes it into a release?

I thought all approved PRs will basically make it into the next release, but that seems not to be the case. I just found out v2.18.1 still supports only i386, x86 & arm which means ppc64le users need to work on the master/main branch and that can sometimes be troublesome. Hope you can enlighten me here 😅 - Thanks!

@mgiessing You thought right, but 2.18.1 is a minor 2.18 release containing only backport PR from master branch (and mainly bug fixing, sometimes feature)
This will be release as part of 2.19.x though 👍

@mgiessing
Copy link
Contributor Author

Okay got it - thanks for clarification!

sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
* Added ppc64le support

* Fixed linting errors
@oomichi oomichi mentioned this pull request May 28, 2022
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 29, 2023
* Added ppc64le support

* Fixed linting errors
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 21, 2023
* Added ppc64le support

* Fixed linting errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants