Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

local volume provisioner should not run on control plane nodes by def… #8805

Merged
merged 1 commit into from
May 10, 2022
Merged

local volume provisioner should not run on control plane nodes by def… #8805

merged 1 commit into from
May 10, 2022

Conversation

spaced
Copy link
Contributor

@spaced spaced commented May 9, 2022 •
edited by oomichi
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

it is very uncommon to run local volumes on control plane nodes.
But we should allow to configure tolerations for special cases.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

local volume provisioner tolerations removed by default.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 9, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @spaced. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from bozzo and oomichi May 9, 2022 12:33
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 9, 2022
@spaced spaced force-pushed the fix-local-volume-provisioner-tolerations branch from 942e3b6 to 5a3863a Compare May 9, 2022 12:55
oomichi
oomichi reviewed May 9, 2022
View reviewed changes
Copy link
Contributor

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/approve

...s/external_provisioner/local_volume_provisioner/templates/local-volume-provisioner-ds.yml.j2
- effect: NoSchedule
operator: Exists
{{ local_volume_provisioner_tolerations | to_nice_yaml(indent=2) | indent(width=8) }}
{% endif %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part had been added since the pull request #2871
But I could not get the point of that.
In addition, the upstream manifest doesn't contain the tolerations as https://github.com/kubernetes-sigs/sig-storage-local-static-provisioner/blob/b5987962ca8c6f53415c4ad683ddea4cb274fec6/helm/generated_examples/baremetal-namespace.yaml#L33
So it is fine to remove it for me by default.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 9, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oomichi, spaced

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2022
@cristicalin
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2022
@cristicalin cristicalin merged commit bb67b65 into kubernetes-sigs:master May 10, 2022
@oomichi oomichi added the kind/feature Categorizes issue or PR as related to a new feature. label May 28, 2022
@oomichi oomichi mentioned this pull request May 28, 2022
Closed
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 30, 2023
@spaced @LuckySB
local volume provisioner should not run on control plane nodes by def…
2db9632 
…ault (kubernetes-sigs#8805)
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 23, 2023
@spaced @LuckySB
local volume provisioner should not run on control plane nodes by def…
41b4ccf 
…ault (kubernetes-sigs#8805)
@spaced spaced deleted the fix-local-volume-provisioner-tolerations branch June 10, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oomichi oomichi oomichi left review comments

@bozzo bozzo Awaiting requested review from bozzo

Assignees

@cristicalin cristicalin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@spaced @k8s-ci-robot @cristicalin @oomichi