Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix helm install with password authentication #9343

Merged
merged 1 commit into from
Oct 13, 2022
Merged

fix helm install with password authentication #9343

merged 1 commit into from
Oct 13, 2022

Conversation

ghostloda
Copy link
Contributor

@ghostloda ghostloda commented Sep 28, 2022 •
edited by floryut

What type of PR is this?

/kind bug

What this PR does / why we need it:

  • Synchronize module throws '[Errno 2] No such file or directory' when using password authentication

  • Use copy instead of synchronize (which requires sshpass)

  • Similar to fix ansible password authentication #6907

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Switch helm install (from synchronize to copy) to support password authentication

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 28, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @ghostloda. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 28, 2022
@liupeng0518
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 29, 2022
@liupeng0518
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 30, 2022
@yankay
Copy link
Member

yankay commented Oct 8, 2022

/lgtm

@yankay
Copy link
Member

yankay commented Oct 8, 2022

Thank you @ghostloda

@ghostloda
Copy link
Contributor Author

ghostloda commented Oct 9, 2022 •
edited

Thank you @ghostloda

My pleasure.
Is there anything else for me to do to get this pr merged? @yankay @oomichi

@yankay
Copy link
Member

yankay commented Oct 9, 2022

Thank you @ghostloda

My pleasure. Is there anything else for me to do to get this pr merged? @yankay @oomichi

HI @oomichi, @liupeng0518 , would you please review it ?

@yankay
Copy link
Member

yankay commented Oct 13, 2022

HI @cristicalin @floryut @liupeng0518 , would you please review the PR ?

floryut
floryut approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghostloda Thank you 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, ghostloda, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2022
@floryut floryut added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit 547ef74 into kubernetes-sigs:master Oct 13, 2022
@hangscer8 hangscer8 mentioned this pull request Oct 20, 2022
Closed
salifou pushed a commit to salifou/kubespray that referenced this pull request Nov 13, 2022
@ghostloda @salifou
fix helm install with password authentication (kubernetes-sigs#9343)
5f099a0
@floryut floryut mentioned this pull request Jan 4, 2023
Closed
enneitex pushed a commit to enneitex/kubespray that referenced this pull request Jan 25, 2023
@ghostloda @enneitex
fix helm install with password authentication (kubernetes-sigs#9343)
156b656
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
@ghostloda @HoKim98
fix helm install with password authentication (kubernetes-sigs#9343)
2f4bdb8
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
@ghostloda @nolimitkun
fix helm install with password authentication (kubernetes-sigs#9343)
7dcde11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yankay yankay yankay approved these changes

@floryut floryut floryut approved these changes

@bozzo bozzo Awaiting requested review from bozzo

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@yankay yankay

@liupeng0518 liupeng0518

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ghostloda @k8s-ci-robot @liupeng0518 @yankay @floryut