Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[etcd] add 3.5.5 hashes, make it default for k8s 1.25 #9419

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

mzaian
Copy link
Contributor

@mzaian mzaian commented Oct 21, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds etcd 3.5.5 and makes it the default for kubernetes 1.25
The release changelog is here https://github.com/etcd-io/etcd/blob/main/CHANGELOG/CHANGELOG-3.5.md

Does this PR introduce a user-facing change?:

[etcd] Default version to 3.5.5 for k8s 1.25.x

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 21, 2022
@oomichi
Copy link
Contributor

oomichi commented Oct 23, 2022

Thanks for updating

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2022
@yankay
Copy link
Member

yankay commented Oct 24, 2022

Thanks @mzaian . Ref to: kubernetes/kubernetes#113197

/lgtm

Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mzaian Perfect, thank you 🙇
/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 24, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, mzaian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2022
@k8s-ci-robot k8s-ci-robot merged commit fe399e0 into kubernetes-sigs:master Oct 24, 2022
salifou pushed a commit to salifou/kubespray that referenced this pull request Nov 13, 2022
@floryut floryut mentioned this pull request Jan 4, 2023
enneitex pushed a commit to enneitex/kubespray that referenced this pull request Jan 25, 2023
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
notCalle pushed a commit to notCalle/kubespray that referenced this pull request Dec 15, 2023
notCalle pushed a commit to notCalle/kubespray that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants