When using cilium CNI, install Cilium CLI #9436

biqiangwu · 2022-10-26T07:35:52Z

Signed-off-by: dcwbq biqiang.wu@daocloud.io

What type of PR is this?
/kind feature

What this PR does / why we need it:
ciliumcli provides rich functions. You must use this tool when you start clustermesh. When using cilium CNI, it is necessary to install it by default

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
Just like calicoctl, it is installed by default

Does this PR introduce a user-facing change?:
None

When using cilium CNI, install Cilium CLI

k8s-ci-robot · 2022-10-26T07:36:00Z

Hi @dcwbq. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

olivierlemasle

CI is failing with 'cilium_cli_version' is undefined.

olivierlemasle · 2022-10-26T08:26:27Z

roles/download/defaults/main.yml

@@ -117,6 +117,7 @@ weave_version: 2.8.1
 pod_infra_version: "3.7"

 cilium_version: "v1.12.1"
+calico_cli_version: "v0.12.4"


I guess it should be cilium_cli_version.

olivierlemasle · 2022-10-26T08:42:00Z

Just like calicoctl, it is installed by default

calicoctl is effectively used by Kubespray when calico is the network plugin:

kubespray/roles/network_plugin/calico/tasks/peer_with_calico_rr.yml

Line 3 in 18efdc2

    
           shell: "{{ bin_dir }}/calicoctl.sh label node  {{ inventory_hostname }} calico-group-id={{ calico_group_id }} --overwrite"

As cilium CLI is not, perhaps it should be made optional.

biqiangwu · 2022-10-26T08:52:06Z

you can also do some status checks and connectivity tests via the cilium-cli (connectivity option is useful). For the original purpose, I wanted to try to enable clustermesh in kubesprayt, so I had to use ciliumcli

you can also do some status checks and connectivity tests via the cilium-cli (connectivity option is useful). For the original purpose, I wanted to try to enable clustermesh in kubesprayt, so I had to use ciliumcli

yankay · 2022-10-26T10:39:31Z

roles/download/defaults/main.yml

+    dest: "{{ local_release_dir }}/cilium"
+    sha256: "{{ ciliumcli_binary_checksum }}"
+    url: "{{ ciliumcli_download_url }}"
+    mirrors:


The cilium cli may not needs mirror.
Only one mirror URL is not reasonable.

The cilium cli may not needs mirror. Only one mirror URL is not reasonable.

THX

yankay · 2022-10-26T10:52:56Z

roles/download/defaults/main.yml

+    url: "{{ ciliumcli_download_url }}"
+    mirrors:
+    - "{{ ciliumcli_download_url }}"
+    unarchive: false


The unarchive may be true

The unarchive may be true

THX

yankay · 2022-10-26T10:53:09Z

roles/network_plugin/cilium/tasks/install.yml

+    src: "{{ local_release_dir }}/cilium"
+    dest: "{{ bin_dir }}/cilium"
+    mode: 0755
+    remote_src: yes


there needs a new line

olivierlemasle · 2022-10-26T12:29:36Z

roles/download/defaults/main.yml

@@ -117,6 +117,7 @@ weave_version: 2.8.1
 pod_infra_version: "3.7"

 cilium_version: "v1.12.1"
+cilium_cli_version: "v0.12.4"


Please update to latest cilium-cli version (v0.12.5).

olivierlemasle

Download fails with:

TASK [download : download_file | Validate mirrors] *******************************************************************************************************************************************
failed: [node1] (item=”https://github.com/cilium/cilium-cli/releases/download/v0.12.5/cilium-linux-amd64.tar.gz“) => {"ansible_loop_var": "mirror", "attempts": 4, "changed": false,
"elapsed": 0, "mirror": "”https://github.com/cilium/cilium-cli/releases/download/v0.12.5/cilium-linux-amd64.tar.gz“", "msg": "Status code was -1 and not [200]: Request failed: <urlopen error
unknown url type: ”https>", "redirected": false, "status": -1, "url": "”https://github.com/cilium/cilium-cli/releases/download/v0.12.5/cilium-linux-amd64.tar.gz“"}

Quotes are invalid, which cause Ansible to think that the URL is "”https://github.com/cilium/cilium-cli/releases/download/v0.12.5/cilium-linux-amd64.tar.gz“".

olivierlemasle · 2022-10-26T17:14:18Z

roles/download/defaults/main.yml

@@ -158,6 +159,7 @@ cni_download_url: "https://github.com/containernetworking/plugins/releases/downl
 calicoctl_download_url: "https://github.com/projectcalico/calico/releases/download/{{ calico_ctl_version }}/calicoctl-linux-{{ image_arch }}"
 calicoctl_alternate_download_url: "https://github.com/projectcalico/calicoctl/releases/download/{{ calico_ctl_version }}/calicoctl-linux-{{ image_arch }}"
 calico_crds_download_url: "https://github.com/projectcalico/calico/archive/{{ calico_version }}.tar.gz"
+ciliumcli_download_url: ”https://github.com/cilium/cilium-cli/releases/download/{{ cilium_cli_version }}/cilium-linux-{{ image_arch }}.tar.gz“


The quotes are wrong: you use ” “ where YAML quotes should be " ".

Signed-off-by: dcwbq <biqiang.wu@daocloud.io>

yankay · 2022-10-27T06:28:21Z

/ok-to-test

olivierlemasle · 2022-10-27T08:16:32Z

Thanks @dcwbq!
/lgtm

yankay · 2022-10-28T04:46:18Z

Thanks @dcwbq!
/lgtm

oomichi · 2022-10-30T23:59:46Z

/approve

k8s-ci-robot · 2022-10-31T00:00:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcwbq, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [oomichi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

biqiangwu · 2022-10-31T07:02:31Z

/approve

THX

Signed-off-by: dcwbq <biqiang.wu@daocloud.io> Signed-off-by: dcwbq <biqiang.wu@daocloud.io>

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 26, 2022

k8s-ci-robot requested review from bozzo and cristicalin October 26, 2022 07:35

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 26, 2022

olivierlemasle reviewed Oct 26, 2022

View reviewed changes

biqiangwu force-pushed the feat/wbq/add_ciliumcli branch from 224c10e to 3fbd891 Compare October 26, 2022 08:30

biqiangwu force-pushed the feat/wbq/add_ciliumcli branch from 3fbd891 to 6e268e8 Compare October 26, 2022 09:01

yankay reviewed Oct 26, 2022

View reviewed changes

biqiangwu force-pushed the feat/wbq/add_ciliumcli branch from 6e268e8 to 37ccd7e Compare October 26, 2022 11:04

olivierlemasle reviewed Oct 26, 2022

View reviewed changes

biqiangwu force-pushed the feat/wbq/add_ciliumcli branch from 37ccd7e to 7f51a63 Compare October 26, 2022 13:05

olivierlemasle suggested changes Oct 26, 2022

View reviewed changes

When using cilium CNI, install Cilium CLI

00e9a07

Signed-off-by: dcwbq <biqiang.wu@daocloud.io>

biqiangwu force-pushed the feat/wbq/add_ciliumcli branch from 7f51a63 to 00e9a07 Compare October 27, 2022 02:04

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 27, 2022

k8s-ci-robot assigned olivierlemasle Oct 27, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2022

k8s-ci-robot assigned yankay Oct 28, 2022

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2022

k8s-ci-robot merged commit 78624c5 into kubernetes-sigs:master Oct 31, 2022

salifou pushed a commit to salifou/kubespray that referenced this pull request Nov 13, 2022

When using cilium CNI, install Cilium CLI (kubernetes-sigs#9436)

03a073e

Signed-off-by: dcwbq <biqiang.wu@daocloud.io> Signed-off-by: dcwbq <biqiang.wu@daocloud.io>

floryut mentioned this pull request Jan 4, 2023

Release Proposal v2.21 #9638

Closed

enneitex pushed a commit to enneitex/kubespray that referenced this pull request Jan 25, 2023

When using cilium CNI, install Cilium CLI (kubernetes-sigs#9436)

d258e40

Signed-off-by: dcwbq <biqiang.wu@daocloud.io> Signed-off-by: dcwbq <biqiang.wu@daocloud.io>

HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023

When using cilium CNI, install Cilium CLI (kubernetes-sigs#9436)

8153420

Signed-off-by: dcwbq <biqiang.wu@daocloud.io> Signed-off-by: dcwbq <biqiang.wu@daocloud.io>

nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023

When using cilium CNI, install Cilium CLI (kubernetes-sigs#9436)

19047ca

Signed-off-by: dcwbq <biqiang.wu@daocloud.io> Signed-off-by: dcwbq <biqiang.wu@daocloud.io>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

When using cilium CNI, install Cilium CLI #9436

When using cilium CNI, install Cilium CLI #9436

biqiangwu commented Oct 26, 2022 •

edited

k8s-ci-robot commented Oct 26, 2022

olivierlemasle left a comment

olivierlemasle Oct 26, 2022

biqiangwu Oct 26, 2022

olivierlemasle commented Oct 26, 2022

biqiangwu commented Oct 26, 2022

yankay Oct 26, 2022

biqiangwu Oct 26, 2022

yankay Oct 26, 2022

biqiangwu Oct 26, 2022

yankay Oct 26, 2022

olivierlemasle Oct 26, 2022

olivierlemasle left a comment

olivierlemasle Oct 26, 2022 •

edited

yankay commented Oct 27, 2022

olivierlemasle commented Oct 27, 2022

yankay commented Oct 28, 2022

oomichi commented Oct 30, 2022

k8s-ci-robot commented Oct 31, 2022

biqiangwu commented Oct 31, 2022

When using cilium CNI, install Cilium CLI #9436

When using cilium CNI, install Cilium CLI #9436

Conversation

biqiangwu commented Oct 26, 2022 • edited

k8s-ci-robot commented Oct 26, 2022

olivierlemasle left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

olivierlemasle commented Oct 26, 2022

biqiangwu commented Oct 26, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

olivierlemasle left a comment

Choose a reason for hiding this comment

olivierlemasle Oct 26, 2022 • edited

Choose a reason for hiding this comment

yankay commented Oct 27, 2022

olivierlemasle commented Oct 27, 2022

yankay commented Oct 28, 2022

oomichi commented Oct 30, 2022

k8s-ci-robot commented Oct 31, 2022

biqiangwu commented Oct 31, 2022

biqiangwu commented Oct 26, 2022 •

edited

olivierlemasle Oct 26, 2022 •

edited