Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting the DirectRouting option on flannel VXLAN #9438

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Allow setting the DirectRouting option on flannel VXLAN #9438

merged 1 commit into from
Oct 31, 2022

Conversation

willtrnr
Copy link
Contributor

@willtrnr willtrnr commented Oct 26, 2022 •
edited by floryut
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:

Adds the possibility to set the DirectRouting option on the flannel VXLAN backend.

Which issue(s) this PR fixes:

Special notes for your reviewer:

It is disabled by default on flannel, by defaulting to false here as well we are fully backward compatible with the previous behavior.

Does this PR introduce a user-facing change?:

[Flannel] Allow setting the DirectRouting option on VXLAN

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 26, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @willtrnr. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 26, 2022
oomichi
oomichi reviewed Oct 27, 2022
View reviewed changes
Copy link
Contributor

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @oomichi

roles/network_plugin/flannel/templates/cni-flannel.yml.j2
@@ -34,7 +34,8 @@ data:
"Backend": {
"Type": "{{ flannel_backend_type }}"{% if flannel_backend_type == "vxlan" %},
"VNI": {{ flannel_vxlan_vni }},
"Port": {{ flannel_vxlan_port }}
"Port": {{ flannel_vxlan_port }},
"DirectRouting": {{ flannel_vxlan_direct_routing | to_json }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not find some document to verify this option is valid.
Could you provide it if possible?

I found flannel-io/flannel#1554 and they said it is not valid.

Copy link
Contributor Author

@willtrnr willtrnr Oct 27, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's in the the flannel backend documentation for VXLAN: https://github.com/flannel-io/flannel/blob/74a34bfa1331cd00d1da86ef8f8a340d9219a224/Documentation/backends.md#vxlan

It's been there for quite some time AFAIK because I had it enabled on an old k8s 1.18 cluster.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your explanation, that is perfect answer for me.

/ok-to-test
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 27, 2022
olivierlemasle
olivierlemasle approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@olivierlemasle olivierlemasle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olivierlemasle, oomichi, willtrnr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1f54cef into kubernetes-sigs:master Oct 31, 2022
salifou pushed a commit to salifou/kubespray that referenced this pull request Nov 13, 2022
@willtrnr @salifou
Add variable to set direct routing on flannel VXLAN (kubernetes-sigs#…
c740ec1 
…9438)
@floryut floryut mentioned this pull request Jan 4, 2023
Closed
enneitex pushed a commit to enneitex/kubespray that referenced this pull request Jan 25, 2023
@willtrnr @enneitex
Add variable to set direct routing on flannel VXLAN (kubernetes-sigs#…
05df895 
…9438)
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
@willtrnr @HoKim98
Add variable to set direct routing on flannel VXLAN (kubernetes-sigs#…
d03bae0 
…9438)
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
@willtrnr @nolimitkun
Add variable to set direct routing on flannel VXLAN (kubernetes-sigs#…
a219d11 
…9438)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivierlemasle olivierlemasle olivierlemasle approved these changes

@liupeng0518 liupeng0518 Awaiting requested review from liupeng0518

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@olivierlemasle olivierlemasle

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@willtrnr @k8s-ci-robot @olivierlemasle @oomichi