Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified the default value of cilium IPAM and added the support for r… #9443

Conversation

biqiangwu
Copy link
Contributor

Signed-off-by: dcwbq biqiang.wu@daocloud.io

What type of PR is this?
/kind feature

What this PR does / why we need it:
cilium IPAM uses "Cluster Scope" mode by default. Also add the parameters required for this mode

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
cilium Default value in "Cluster Scope" mode

  cluster-pool-ipv4-cidr: 10.0.0.0/8
  cluster-pool-ipv4-mask-size: "26"
  cluster-pool-ipv6-cidr: fd00::/104
  cluster-pool-ipv6-mask-size: "120"

But I think the cluster Pod CIDR is too big, and "kube_pods_subnet" is more reasonable.

Does this PR introduce a user-facing change?:
cilium IPAM default mode changed from "Kubernetes" to "Cluster Scope"

cilium IPAM uses "Cluster Scope" mode by default. Also add the parameters required for this mode

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 28, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @dcwbq. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 28, 2022
@biqiangwu biqiangwu force-pushed the feat/wbq/add_cilium_IPAM_parameter branch 2 times, most recently from 8d4906a to 26168b3 Compare October 28, 2022 05:16
@yankay
Copy link
Member

yankay commented Oct 28, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 28, 2022
…elated parameters

Signed-off-by: dcwbq <biqiang.wu@daocloud.io>
@biqiangwu biqiangwu force-pushed the feat/wbq/add_cilium_IPAM_parameter branch from 26168b3 to 62723d5 Compare October 28, 2022 06:45
@cristicalin
Copy link
Contributor

Thanks @dcwbq !

/approve
/cc @floryut @oomichi

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, dcwbq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2023
@cristicalin
Copy link
Contributor

/retest

@oomichi
Copy link
Contributor

oomichi commented Mar 14, 2023

Sorry for missing this pull request in long time.
looks good for me.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 2ae3ea9 into kubernetes-sigs:master Mar 14, 2023
@lutskevich
Copy link

@oomichi Hi! It has mistakes. fix #9896

@floryut
Copy link
Member

floryut commented Mar 16, 2023

wow you are right..


# Cluster Pod CIDRs use the kube_pods_subnet value by default.
# If your node network is in the same range you will lose connectivity to other nodes
cilium_pool_cidr: "{{ kube_pods_subnet | 10.233.64.0/18 }}"
Copy link

@okaufmann okaufmann Mar 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcwbq Should this not be "{{ kube_pods_subnet | default('10.233.64.0/18') }}" (in case this variable is not set / for backward compability)?

nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
…elated parameters (kubernetes-sigs#9443)

Signed-off-by: dcwbq <biqiang.wu@daocloud.io>
@yankay yankay mentioned this pull request May 15, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
…elated parameters (kubernetes-sigs#9443)

Signed-off-by: dcwbq <biqiang.wu@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants