-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified the default value of cilium IPAM and added the support for r… #9443
Modified the default value of cilium IPAM and added the support for r… #9443
Conversation
Hi @dcwbq. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
8d4906a
to
26168b3
Compare
/ok-to-test |
…elated parameters Signed-off-by: dcwbq <biqiang.wu@daocloud.io>
26168b3
to
62723d5
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cristicalin, dcwbq The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Sorry for missing this pull request in long time. /lgtm |
wow you are right.. |
|
||
# Cluster Pod CIDRs use the kube_pods_subnet value by default. | ||
# If your node network is in the same range you will lose connectivity to other nodes | ||
cilium_pool_cidr: "{{ kube_pods_subnet | 10.233.64.0/18 }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dcwbq Should this not be "{{ kube_pods_subnet | default('10.233.64.0/18') }}"
(in case this variable is not set / for backward compability)?
…elated parameters (kubernetes-sigs#9443) Signed-off-by: dcwbq <biqiang.wu@daocloud.io>
…elated parameters (kubernetes-sigs#9443) Signed-off-by: dcwbq <biqiang.wu@daocloud.io>
Signed-off-by: dcwbq biqiang.wu@daocloud.io
What type of PR is this?
/kind feature
What this PR does / why we need it:
cilium IPAM uses "Cluster Scope" mode by default. Also add the parameters required for this mode
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
cilium Default value in "Cluster Scope" mode
But I think the cluster Pod CIDR is too big, and "kube_pods_subnet" is more reasonable.
Does this PR introduce a user-facing change?:
cilium IPAM default mode changed from "Kubernetes" to "Cluster Scope"